Pull requests failing lint tests - BUT appears to be in code not changed.

[rorymac]

Hello All

I have submitted two pull requests BUT the lint check fails, it appears that the failure is on code not submitted to the pull request.

Internet searching has not revealed if this is an error and or how to fix this.

Has anybody manged to pass through this and or is there a lint guideline (if the code is badly structured.) that you can guide me to?

Also bonus question !

Should pull requests be submitted to develop or master?

Thanks
RM

[bug-or-feature]

The general pattern is to do development on the develop branch, hence the name. Occasionally, when things are stable, Rob pushes everything on develop to master. The idea is that master stays stable. So, really your PRs should be submitted to develop

The lint checks are just running Black to make the code formatting consistent. You should ensure your changes pass the tests before submitting, see the Black docs. There is a discussion about it here

Ideally, code that doesn't pass the lint test should not be allowed into the repo. But sometimes Rob merges a failing PR. That complicates things