Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: toolbar doesn't move with firefox addressbar #50

Closed
ikke-t opened this issue Jul 10, 2023 · 3 comments
Closed

android: toolbar doesn't move with firefox addressbar #50

ikke-t opened this issue Jul 10, 2023 · 3 comments

Comments

@ikke-t
Copy link

ikke-t commented Jul 10, 2023

Hi,

See screenshot how android firefox dynamic addressbar disappearing leaves birdui toolbar element hanging:

Screenshot_2023-07-10-18-30-43-15_984e1414ae90666a90f12ff17ec14a7f

While fixing it, why not autohide birdUI toolbar as well 🙏

I can look after a similar issue I made for Elk, which got fixed.

This is related to another issue. Sometimes the button touch is miscalculated by the same amount when FF toolbar moves.

So the page should take into account if ff toolbar is visible or not. Now it fails noticing the change.

@ikke-t
Copy link
Author

ikke-t commented Jul 10, 2023

See elk issue here elk-zone/elk#1558

@ronilaukkarinen
Copy link
Owner

ronilaukkarinen commented Jul 10, 2023

This is not really Mastodon Bird UI issue, because that code has nothing to do with Mastodon Bird UI 😅 It is related to my fork of Mastodon and never was implemented with Mastodon Bird UI, only on mementomori.social as a feature.

However, I tested it on Firefox and didn't spot any issues 🤔

I suggest using a Chrome app for Mastodon for now or if it bugs too much I can perhaps disable the feature, but I have no idea how to solve it otherwise.

Firefox on Android 13 (Google Pixel/OP8T):

ezgif com-optimize (1)

@ikke-t
Copy link
Author

ikke-t commented Jul 10, 2023

Yes, it doesn't always happen. I wonder why is that. Sometimes this and elk both gets confused, like missing some resize event. Then it stays. Also latest android on 1+ here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants