Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods to list/add/remove hooks #126

Open
hadley opened this issue Apr 28, 2015 · 3 comments
Open

Methods to list/add/remove hooks #126

hadley opened this issue Apr 28, 2015 · 3 comments

Comments

@hadley
Copy link
Member

hadley commented Apr 28, 2015

Not strictly part of libgit2, but would be nice to have
@stewid
Copy link
Member

stewid commented May 8, 2015

Hooks are not supported by libgit2. However, there is an open PR to add initial support for hooks libgit2/libgit2#3004

@stewid
Copy link
Member

stewid commented May 8, 2015

Before adding this functionality to git2r, wait and see which API functions libgit2 adds.

@jennybc
Copy link
Member

jennybc commented Nov 16, 2015

The PR referenced above (libgit2/libgit2#3004) got closed with this conclusion: "libgit2 is not going to get hooks as such". So the stuff @hadley's suggesting will not be coming from libgit2.

I ended up here trying to confirm that git2r::commit() does not honour pre-commit hooks. Indeed it does not and now I know why. For the same reason, clients like GitHub for Windows do not honour pre-commit hooks. ¯_(ツ)_/¯.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hadley @jennybc @stewid