From 827848ada457c9a4213493c28e7e1b7aac95b548 Mon Sep 17 00:00:00 2001
From: Thierry Onkelinx <thierry.onkelinx@inbo.be>
Date: Wed, 20 Jan 2021 15:57:26 +0100
Subject: [PATCH] update CRAN comments

---
 cran-comments.md       | 35 ++++++++++++++++++++++++++++-------
 vignettes/split_by.Rmd |  2 +-
 2 files changed, 29 insertions(+), 8 deletions(-)

diff --git a/cran-comments.md b/cran-comments.md
index b942d48..692ec2b 100644
--- a/cran-comments.md
+++ b/cran-comments.md
@@ -1,12 +1,12 @@
 ## Test environments
 * local
-    * ubuntu 18.04.3 LTS, R 3.6.1
-* travis-ci
-    * trusty, oldrel
-    * xenial, release and devel
-    * osx, release
-* AppVeyor 
-    * Windows Server 2012 R2 x64, R 3.6.1 Patched
+    * ubuntu 18.04.5 LTS, R 4.0.3
+* github actions
+    * macOS-latest, release
+    * windows-latest, release
+    * ubuntu 20.04, devel
+    * ubuntu 16.04, oldrel
+    * checklist package: ubuntu 20.04.1, R 4.0.3
 * r-hub
     * Windows Server 2008 R2 SP1, R-devel, 32/64 bit
     * Ubuntu Linux 16.04 LTS, R-release, GCC
@@ -15,3 +15,24 @@
 ## R CMD check results
 
 0 errors | 0 warnings | 0 note
+
+r-hub gave a few false positive notes
+
+* Windows Server 2008 R2 SP1, R-devel, 32/64 bit
+
+```
+Possibly mis-spelled words in DESCRIPTION:
+  rdata (28:22, 31:33, 36:20, 40:48, 41:20, 43:24, 44:62, 45:62)
+  workflow (41:37, 44:15, 44:36)
+```
+
+* Fedora Linux, R-devel, clang, gfortran
+
+```
+Possibly mis-spelled words in DESCRIPTION:
+  rdata (28:22, 31:33, 36:20, 40:48, 41:20, 43:24, 44:62, 45:62)
+```
+
+Ubuntu Linux 16.04 LTS, R-release, GCC failed on r-hub because ICU is not
+available on that build.
+
diff --git a/vignettes/split_by.Rmd b/vignettes/split_by.Rmd
index 490a08a..90cea15 100644
--- a/vignettes/split_by.Rmd
+++ b/vignettes/split_by.Rmd
@@ -136,7 +136,7 @@ We add an `index.tsv` containing the combinations of the `split_by` variables an
 This hash becomes the base name of the partial data files.
 
 Splitting the dataframe into smaller files makes them easier to handle in version control system.
-The overall size depends on the amount of replication in the dataframe.
+The total size depends on the amount of replication in the dataframe.
 More on that in the next section.
 
 ## When to Split the Dataframe