Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering is wrong for some pages #38

Open
rougier opened this issue Feb 27, 2018 · 5 comments
Open

Rendering is wrong for some pages #38

rougier opened this issue Feb 27, 2018 · 5 comments

Comments

@rougier
Copy link
Owner

rougier commented Feb 27, 2018

After @akuroiwa PR merging, some page display is weird (components.html, getting-started.html).
Probably some page template is wrong relatively to new bootstrap.

@akuroiwa
Copy link
Contributor

I'm very sorry.
I guess that there are differences between Bootstrap v3.1.1 and v3.3.7. To make matters worse, I appended v4.

@rougier
Copy link
Owner Author

rougier commented Feb 27, 2018

No problem. But some pages render ok and some other not. Do you have any idea what could be the reason ?

@akuroiwa
Copy link
Contributor

I tried quick-fix solution:

cd test/
rst2bootstrap3 --stylesheet="https://maxcdn.bootstrapcdn.com/bootstrap/3.1.1/css/bootstrap.min.css" ~/src/bootstrap-rst/doc/components.rst components.html

It works. Drastic measure is:

  1. Delete the contents of bootstrap/ directory.
  2. Copy Bootstrap v3.1.1 files.
  3. Put the v4.0.0-beta.2 of bootstrap/css/carousel.css and bootstrap/js/holder.min.js back into the directory.
  4. Edit STYLESHEET of Makefile and stylesheet_path of bootstrap.traditional_main().

If you prefer BootstrapCDN URL to local files, please skip the second step.

@rougier
Copy link
Owner Author

rougier commented Feb 28, 2018

Can you make a PR for that?
What is the difference between Bootstrap and BootstrapCDN?

@akuroiwa
Copy link
Contributor

akuroiwa commented Mar 1, 2018

I will try. It will take a few days.

Since I don't know the difference, I will delete local files.
If you have any problems, please add them after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants