Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a github pull request does not update the test email #39

Open
keybounce opened this issue Oct 27, 2017 · 0 comments
Open

Updating a github pull request does not update the test email #39

keybounce opened this issue Oct 27, 2017 · 0 comments

Comments

@keybounce
Copy link

So I am new to github pull requests.

(Background: I'm not new to email systems. But I have no clue how to configure sendmail-based systems, consider that config file to be black magic, and Apple doesn't give any docs. It does not "just work" out of the box. My default email setup uses Mail.app as an imap client.)

I attempted to make a pull request, #421 -- git/git#421 . The test email showed problems -- the message at the front wasn't formatted right, and the subject wasn't correct.

So, a little fixing, and at least the message is right. Another test, ... and the test message has not changed, does not reflect the updated message.

Also, even though I changed the subject in the pull request, the subject provided is still from the original github commit

How do I fix what I am doing wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant