Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7 support #518

Closed
mnifakram opened this issue Dec 3, 2021 · 3 comments
Closed

Rails 7 support #518

mnifakram opened this issue Dec 3, 2021 · 3 comments

Comments

@mnifakram
Copy link

Hello,

Steps to reproduce:

  1. rails new test --dev --force
  2. rails generate scaffold User name username email
  3. rails generate migration AddDeletedAtToUser deleted_at:datetime:index
  4. add acts_as_paranoid to app/models/user.rb
  5. rails c
  6. User.first

When trying to load a model that use this gem I got the following error lib/active_record/scoping/default.rb:123:in default_scope': unknown keyword: :conditions (ArgumentError)

Any ideas on how to quickly fix it or when support will be considered for Rails 7

Thank you so much for the great work done on this gem.

@ryanwi
Copy link

ryanwi commented Dec 9, 2021

It appears the gem won't even install on Rails 7?

  s.add_dependency 'activerecord', '>= 4.0', '< 6.2'

I am curious to know as well if this gem will be supporting Rails 7?

UPDATE: I see the #516 PR now, apologies for missing that.

@gordysc
Copy link

gordysc commented Dec 16, 2021

@mnifakram , I'd recommend forking the repository in the #516 PR while we wait on their PR to be merged. I hit the same issue as you and it was because bundler had resolved a much older version of this gem (1.2.0) which causes the unknown keyword error to occur. I'm using the rails7 branch of the PR from #516 and I haven't had any problems

@radar
Copy link
Collaborator

radar commented Dec 18, 2021

Done in v2.5.0.

@radar radar closed this as completed Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants