Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the files list includes entire gem as a dependency #525

Closed
jasonfb opened this issue Jan 31, 2022 · 1 comment
Closed

the files list includes entire gem as a dependency #525

jasonfb opened this issue Jan 31, 2022 · 1 comment
Labels

Comments

@jasonfb
Copy link
Contributor

jasonfb commented Jan 31, 2022

all gemfiles are included by default....

these should not include testing files and only include the core library files..

s.files = `git ls-files`.split("\n")

as a result, when you try to deploy it to Heroku, you get:


remote:  !     LoadError: cannot load such file -- rspec/expectations
remote:  !     /tmp/build_3385c548/vendor/bundle/ruby/2.7.0/gems/bootsnap-1.9.1/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:34:in `require'
remote:  !     /tmp/build_3385c548/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.4.1/lib/active_support/dependencies.rb:332:in `block in require'
remote:  !     /tmp/build_3385c548/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.4.1/lib/active_support/dependencies.rb:299:in `load_dependency'
remote:  !     /tmp/build_3385c548/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.4.1/lib/active_support/dependencies.rb:332:in `require'
remote:  !     /tmp/build_3385c548/vendor/bundle/ruby/2.7.0/gems/paranoia-2.4.3/lib/paranoia/rspec.rb:1:in `<main>'

https://gist.github.com/jasonfb/20c3b0a85baf59824fddcdfbc5a7b5f4

@mathieujobin
Copy link
Collaborator

will be released as v2.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants