Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: wrong scope detected for wix installer #953

Closed
1 task done
a-mnich opened this issue Dec 8, 2024 · 1 comment
Closed
1 task done

[Bug]: wrong scope detected for wix installer #953

a-mnich opened this issue Dec 8, 2024 · 1 comment
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@a-mnich
Copy link

a-mnich commented Dec 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

When creating an update for Pandoc the scopes aren't correct

komac update JohnMacFarlane.Pandoc --version 3.6 --urls https://github.com/jgm/pandoc/releases/download/3.6/pandoc-3.6-windows-x86_64.msi

Komac correctly detects the ALLUSERS installer switch but sets the manifest wide scope to user even though ALLUSERS=1 forces a per-machine install (AllUSERS Property)
I've only seen this behavior for Pandoc, therefore I'm not sure whether it's a specific problem with its installer. (microsoft/winget-pkgs#197015, microsoft/winget-pkgs#165049)
Maybe a detection of ALLUSERS=1 could be used as fallback to set the installer scope to machine even when komac would usually detect it otherwise?

image

@a-mnich a-mnich added bug Something isn't working help wanted Extra attention is needed labels Dec 8, 2024
@russellbanks
Copy link
Owner

Thanks for reporting! This is because the ALLUSERS value is missing in the MSI property table which usually indicates a per-user install scope. However, Pandoc lets you modify this in the installer:

image

Therefore, we can check the MSI control table for anything that controls ALLUSERS:

{4BD32AEA-16C7-454B-8BC8-1573CB1B901C}

As this is present in Pandoc, we can consider the scope to be agnostic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants