Dependency of rustc_fluent_macros getting compiled with -Ztls-model=initial-exec #134863

bjorn3 · 2024-12-28T21:59:25Z

Proc macros must not be compiled with -Ztls-model=initial-exec as -Ztls-model=initial-exec is incompatible with dlopen. Glibc is somewhat lenient with dlopening dylibs compiled with -Ztls-model=initial-exec for as long as there is room, but other libc implementations may not provide enough room or provide room at all. For example on FreeBSD trying to use rustc_driver results in the following error:

https://cirrus-ci.com/task/4557776715776000

error: /.rustup/toolchains/nightly-2024-12-28-x86_64-unknown-freebsd/lib/rustlib/x86_64-unknown-freebsd/lib/librustc_fluent_macro-60e8ff74c2f2aaa5.so: No space available for static Thread Local Storage
  --> src/lib.rs:16:1
   |
16 | extern crate rustc_middle;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^

To fix this issue, the set of exclusions at

rust/src/bootstrap/src/bin/rustc.rs

Lines 166 to 173 in ceb0441

    
           // `-Ztls-model=initial-exec` must not be applied to proc-macros, see 
        
           // issue https://github.com/rust-lang/rust/issues/100530 
        
           if env::var("RUSTC_TLS_MODEL_INITIAL_EXEC").is_ok() 
        
               && crate_type != Some("proc-macro") 
        
               && !matches!(crate_name, Some("proc_macro2" | "quote" | "syn" | "synstructure")) 
        
           { 
        
               cmd.arg("-Ztls-model=initial-exec"); 
        
           }

needs to be updated to include all direct and indirect dependencies of the rustc_fluent_macros crate.

The text was updated successfully, but these errors were encountered:

…zkan bootstrap: Don't apply -Ztls-model=initial-exec to deps of proc-macros Fixes rust-lang#134863 1. Checks if a crate name is in a static list before applying the flag 2. Adds a tidy check that gathers transitive deps of proc macros and ensures the list is up to date cc `@bjorn3` - the issue specifies `rustc_fluent_macro` but I assume this applies to all proc macro crates.

…zkan bootstrap: Don't apply -Ztls-model=initial-exec to deps of proc-macros Fixes rust-lang#134863 1. Checks if a crate name is in a static list before applying the flag 2. Adds a tidy check that gathers transitive deps of proc macros and ensures the list is up to date cc ``@bjorn3`` - the issue specifies `rustc_fluent_macro` but I assume this applies to all proc macro crates.

bjorn3 added A-thread-locals Area: Thread local storage (TLS) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2024

rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 28, 2024

clubby789 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 28, 2024

clubby789 mentioned this issue Dec 28, 2024

bootstrap: Don't apply -Ztls-model=initial-exec to deps of proc-macros #134865

Merged

bors closed this as completed in c156614 Dec 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dependency of rustc_fluent_macros getting compiled with -Ztls-model=initial-exec #134863

Dependency of rustc_fluent_macros getting compiled with -Ztls-model=initial-exec #134863

bjorn3 commented Dec 28, 2024

Dependency of rustc_fluent_macros getting compiled with -Ztls-model=initial-exec #134863

Dependency of rustc_fluent_macros getting compiled with -Ztls-model=initial-exec #134863

Comments

bjorn3 commented Dec 28, 2024