Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for showing current speed in backup progress bar #1356

Closed
jullanggit opened this issue Nov 17, 2024 · 3 comments
Closed

Option for showing current speed in backup progress bar #1356

jullanggit opened this issue Nov 17, 2024 · 3 comments
Labels
S-triage Status: Waiting for a maintainer to triage this issue/PR

Comments

@jullanggit
Copy link
Contributor

Proposal

Having a config/cli option for seeing the current (instead of the average) speed in the backup progress bar

Reason

I would personally really enjoy seeing the speed spike up (and dip down) in real time. Keeping the time estimate an average is probably a good idea, but I feel like an option to set the speed to real-time wouldn't cause any harm and would be really cool!

Thanks for considering this option :)

@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Nov 17, 2024
@aawsome
Copy link
Member

aawsome commented Nov 17, 2024

Hi @jullanggit, thanks for opening this issue.
Note that rustic currently already shows the current speed - which is averaged/smoothed a bit.

The point is that a concept of "actual speed" is a very complicated. We just can say that at some given points in time, we made a progress of a given amount of bytes. Calculating a speed always includes doing some averaging...

@jullanggit
Copy link
Contributor Author

jullanggit commented Nov 18, 2024

Thanks for the quick answer! Would it maybe be possible to have an option to change how much smoothing is applied? The reason I even noticed this is that the counter still shows multi-MB/s speeds, even tough the total count (in MB) hasn't changed for a few seconds. Again, nothing too big, just something that would maybe be fun to play around with!

@jullanggit
Copy link
Contributor Author

I have looked a bit into the source code for the progress bar and came to the conclusion, that it would probably be needlessly complicated to show the "current speed" / average less, so I will be closing this issue.
Nonetheless, thanks for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-triage Status: Waiting for a maintainer to triage this issue/PR
Projects
None yet
Development

No branches or pull requests

2 participants