Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run-before scripts will not run if the source paths are not present? #1373

Closed
aur3l14no opened this issue Dec 2, 2024 · 1 comment · Fixed by #1374
Closed

run-before scripts will not run if the source paths are not present? #1373

aur3l14no opened this issue Dec 2, 2024 · 1 comment · Fixed by #1374
Labels
A-commands Area: Related to commands in `rustic` A-config Area: Related to the config file functionality and format C-bug Category: Something isn't working as expected

Comments

@aur3l14no
Copy link

If the sources are not present the run-before hook would not run at all. This kills use cases like using run-before hook to trigger fs snapshots creation.

rustic/src/commands/backup.rs

Line 187 in 852635e

let config_snapshot_sources: Vec<_> = snapshot_opts

@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Dec 2, 2024
@aawsome aawsome added C-bug Category: Something isn't working as expected A-commands Area: Related to commands in `rustic` A-config Area: Related to the config file functionality and format and removed S-triage Status: Waiting for a maintainer to triage this issue/PR labels Dec 2, 2024
@aawsome aawsome mentioned this issue Dec 2, 2024
Merged
@aawsome
Copy link
Member

aawsome commented Dec 2, 2024

Thanks for reporting @aur3l14no. I think #1374 will fix this.

@aawsome aawsome closed this as completed in f14a8bb Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-commands Area: Related to commands in `rustic` A-config Area: Related to the config file functionality and format C-bug Category: Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: run backup hooks before checking source dir rustic-rs/rustic
2 participants
@aur3l14no @aawsome