Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong feature name for webpki? #274

Open
aviramha opened this issue May 26, 2024 · 1 comment
Open

wrong feature name for webpki? #274

aviramha opened this issue May 26, 2024 · 1 comment
Labels
next-major-release breaking changes that should happen in the next major release

Comments

@aviramha
Copy link

In Cargo.toml:
https://github.com/rustls/hyper-rustls/blob/78d214b518e9238da26958bc37c699490332283d/Cargo.toml#L40C1-L41C1
in code:
https://github.com/rustls/hyper-rustls/blob/78d214b518e9238da26958bc37c699490332283d/src/config.rs#L35C1-L36C1

This must be an issue, no?
@ctz
Copy link
Member

ctz commented May 26, 2024

Yes that seems like a typo in Cargo.toml. In practice it doesn't have any effect (because every optional dependency implies a feature of the same name).

@ctz ctz added the next-major-release breaking changes that should happen in the next major release label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next-major-release breaking changes that should happen in the next major release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctz @aviramha