Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize CMake for examples to use external librustls #519

Open
cpu opened this issue Dec 28, 2024 · 0 comments
Open

Generalize CMake for examples to use external librustls #519

cpu opened this issue Dec 28, 2024 · 0 comments

Comments

@cpu
Copy link
Member

cpu commented Dec 28, 2024

As a follow-up to #506 it would be nice to remove the need for the 3rd party https://github.com/cpu/rustls-ffi-test repo for smoke-testing built artifacts.

The existing client/server examples would be perfect for this, except that the CMakeLists.txt they use unconditionally build librustls from scratch using cargo-c pointed to output into the cmake build root.

It would be better if we generalized this so that if an existing librustls was available (e.g. from being discovered via pkg-config) the build would prefer to use that copy of the lib instead of building it anew. This would let us use the test binaries with the pre-built artifacts during the testing phase of the binary artifact release CI process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant