Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsoundness in ninjabook #2150

Open
lwz23 opened this issue Dec 2, 2024 · 0 comments
Open

Unsoundness in ninjabook #2150

lwz23 opened this issue Dec 2, 2024 · 0 comments

Comments

@lwz23
Copy link

lwz23 commented Dec 2, 2024

see ninja-quant/ninjabook#3 for detail.
Description
The get_mutand get function in the Orderbook implementation uses unsafe code to call Buffer::get_unchecked_mut, bypassing bounds checking. This function is unsound because it allows access to an arbitrary index without ensuring that the index is within bounds. If the caller provides an out-of-bounds index, the program will invoke undefined behavior (UB).

author didn't reply yet, so no patched version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant