Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog and document breaking changes #6

Open
aminya opened this issue Dec 31, 2021 · 2 comments
Open

Add changelog and document breaking changes #6

aminya opened this issue Dec 31, 2021 · 2 comments

Comments

@aminya
Copy link

aminya commented Dec 31, 2021

0.4 to 0.5 had some breaking changes, which are not documented anywhere.

For example, from_case no longer works on str.

@rutrum
Copy link
Owner

rutrum commented Dec 31, 2021

Hi, breaking changes were not intended, so thank you for bringing this to my attention. I rewrote the trait implementation for Casing. You can see a major change in this commit:

f74aed7#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759

Did from_case every work on str? It currently works on, and did work on &str. Can you give me an example of something that succeeded in 0.4 and fails now? I might be misunderstanding something.

@rutrum
Copy link
Owner

rutrum commented Dec 20, 2024

As I move forward into 0.7.0 I will start documenting changes best I can. I am relying on the "0.x is unreliable" part of semver perhaps a little too heavily, since this library is relatively mature. I may in the future look backwards and try to document the breaking changes between older versions.

As far as your note on str, I am in the process of changing the trait bounds for the Casing trait which should hopefully increase the number of string types case conversion should work upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants