Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique_everseen should be templated by a hash function and use a different set object #90

Open
nimrodfg opened this issue Dec 26, 2022 · 1 comment
Assignees

Comments

@nimrodfg
Copy link

Currently we can't use unique_everseen for proto-buffs, or any element that doesn't have std::hash.
Would make sense to make functions for which its relevant to be templated by equality and hash operators.

@ryanhaining
Copy link
Owner

Good point. I added an overload. I'm not sure if there's a good/right way to get the pipe syntax working with the new version though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants