Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message not rendering after transitionTo call. #11

Open
minirobotdan opened this issue May 22, 2014 · 7 comments
Open

Message not rendering after transitionTo call. #11

minirobotdan opened this issue May 22, 2014 · 7 comments

Comments

@minirobotdan
Copy link

Hi there Ryan, the problem I'm having is the flashmessage call renders when I don't use transitionTo, but when I do it does not render. As requested I've made a JSBin of the issue I've been having. Annoyingly, the JSBin works. Barring using Ember App Kit and the local storage adapter, it's essentially how my code is laid out.

http://jsbin.com/denitora/3/edit

I did manage to get some info that might pertain to the problem- Using the Ember Chrome Plugin and putting some console logs in your code, I found out that the currentMessage value survives the route transition, but doesn't seem to render.

screen shot 2014-05-22 at 15 42 07

This would indicate that the problem might be somewhere in the helper.

Any suggestions?

@Emerson
Copy link
Collaborator

Emerson commented Jun 23, 2014

I'm seeing this as well. Looking into it now.

@Emerson
Copy link
Collaborator

Emerson commented Jun 23, 2014

I can confirm that all tests are passing with Ember Canary Latest and Handlebars 1.3...

@Emerson
Copy link
Collaborator

Emerson commented Jun 23, 2014

@minirobotdan - Can you pull down the latest build and try it out? Would love to know if your problem has been resolved.

@MatthewHager
Copy link

This is happening on my application. Can confirm that the message shows up in the ember chrome plugin. I'm using an ember-cli based application. My code looks like this:

import Ember from 'ember';

export default Ember.Route.extend({
  actions: {
    passwordResetSuccess: function() {
      this.flashMessage('Password reset email sent.', 'message');
      this.transitionTo('sign-in');
    }
  }
});
    {{#flashMessage}}
    <div {{bind-attr class="message.type"}}>
      {{message.text}}
    </div>
    {{/flashMessage}}

I'm using ember 1.7.0

@visoft
Copy link

visoft commented Oct 1, 2014

I'm having the same problem as @MatthewHager, using Ember 1.7.0.

@Emerson
Copy link
Collaborator

Emerson commented Oct 1, 2014

Hmmm, I'll try to have a look at this tonight. Thanks for the info.

@visoft
Copy link

visoft commented Oct 1, 2014

@Emerson The code in your repo works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants