You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#81 and #83 highlight something discussed a while ago, which is CI testing of notebooks and examples.
The strategy up until now has been to manually test notebooks and examples prior to a release, but this did not always work out as smoothly as I had hoped.
We might want to start running a CI job testing notebooks and examples when a PR is merged to develop on GitLab. For both cases, the expected outcome should be error-free execution.
I see two issues with this as it stands now:
the goPredSim examples expect prior download of files (all other examples can be run directly from the repo)
Many notebooks require download of files, and we would have to ignore the Colab init on local testing
The text was updated successfully, but these errors were encountered:
Preliminary results: The code below runs all notebooks and reports which pass and which fail. However, it will run all cells, including the pip install, as papermill does not have a way to skip cells (nteract/papermill#429). So we need a way to skip cells, even if it's just "skip the first cell unconditionally". We could use the nbconvert cli which can do that with some tricks (nteract/papermill#494 (comment)) or we can try wrapping that so that the pip installs are skipped during test.
The good thing about this is that downloading files works same as in colab.
Hey @konstin -- just been dropping by on notebook testing issues as i've release nbmake.
Only issue is this is the first case i've seen where cell-skipping is required. Potentially an interesting feature. Keen to hear your feedback, if any!
I did relize that some notebooks need updating in the mantime, e.g. the ones from the protocol & supervised extract. Probably anotherone to add to the #125 thread
#81 and #83 highlight something discussed a while ago, which is CI testing of notebooks and examples.
The strategy up until now has been to manually test notebooks and examples prior to a release, but this did not always work out as smoothly as I had hoped.
We might want to start running a CI job testing notebooks and examples when a PR is merged to develop on GitLab. For both cases, the expected outcome should be error-free execution.
I see two issues with this as it stands now:
The text was updated successfully, but these errors were encountered: