Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PENDING_MULTISIG_TRANSACTION event is emitted before confirmations are added #2391

Open
Uxio0 opened this issue Jan 20, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Uxio0
Copy link
Member

Uxio0 commented Jan 20, 2025

For sending notifications and events to the event queue we use Django signals. confirmations are stored in a different table. So first we store MultisigTransaction, and then we create Confirmation and link it using a foreign key. The problem is that the event triggers when MultisigTransaction is created, so if a client checks the endpoint the transaction will miss the signers. Delay should be only a few seconds, but that's not acceptable.

Solutions

  • Invalidate signals and trigger then manually at the end: tricky and hacky solution
  • Remove signals and manually manage when events should be emitted. This gives us total control but requires a big refactor of the service

Temporary we recommend to clients to add a small delay when they receive a PENDING_MULTISIG_TRANSACTION or EXECUTED_MULTISIG_TRANSACTION event

@Uxio0 Uxio0 added the bug Something isn't working label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant