Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Risk mitigation] Redefine integration extension #2113

Closed
1 task done
schmanu opened this issue Jun 15, 2023 · 2 comments · Fixed by #3062
Closed
1 task done

[Risk mitigation] Redefine integration extension #2113

schmanu opened this issue Jun 15, 2023 · 2 comments · Fixed by #3062
Labels
enhancement New feature or request

Comments

@schmanu
Copy link
Member

schmanu commented Jun 15, 2023

What is the feature about

In our initial risk mitigation module / integration we scan the transaction data.

We should extend this integration by

  • Scanning EIP-712 message requests: With off-chain integrations growing, these messages can contain harmful payloads which can potentially steal funds / nfts.

The list of requirements

  • scan off-chain messages: Our new off-chain message modal should also send a scan request with the message as payload.

Designs/sketches

tbd

@schmanu schmanu added the enhancement New feature or request label Jun 15, 2023
@katspaugh
Copy link
Member

Related: safe-global/safe-react-apps#702

@schmanu
Copy link
Member Author

schmanu commented Jan 4, 2024

@katspaugh I removed the requirements around passing the domain to redefine as WalletConnect now includes their own domain check and we revamped our WalletConnect connection widget with those warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants