-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does this package support multiple languages? (in development) #69
Comments
Hi @Afluxx , thanks for your concern, actually, there is a plan for implementing this feature hopefully in the next major version next month 👍 |
Hi! Any news on this? |
@saleem-hadad looking forward to this update! |
I'm currently working with my team on a private project, once I finish I'll come back developing this for sure hopefully within two weeks will be ready @Afluxx @rayoplateado |
also, I'm working on two things for this package:
|
This isn't directly related to the question, but in case some one else wants to know: I am developing a SAAS application and as such, version's aren't that important (since there is only one version of the app on the server). So I updated the configuration file to show language tags instead of the versions...
and on the folder structure did the same
It works out pretty great, plus you get the language key on the url, so you can direct users based on their preferences. Hope this helps! |
Hello everyone 'versions' => [
'default' => '1.0',
'published' => [
'1.0' => [
'en' => 'ltr',
'ar' => 'rtl'
],
'1.1' => [
'en' => 'ltr',
]
]
], what do you think guys? |
Suggestion:
If you are planning to introduce Language Support, there really is no
reason to specify RTL or not, since the languages that use RTL are standard
(mainly 'ar' [arabic] and 'he' [hebrew], more info here
<https://en.wikipedia.org/wiki/Right-to-left>)
So why not just create a function with constant values and if the desired language hits only those keys, automatically shift to RTL. This will avoid incorrect
configuration and will greatly simply your structure and become a basic array.
*Example*:
'versions' => [ 'default' => '1.0', 'published' => [
'1.0' => [ 'en', 'ar' ], '1.1' => [ 'en' ] ]],
…On Sat, Feb 9, 2019 at 5:49 PM Saleem Hadad ***@***.***> wrote:
Hello everyone
Now after I finished the internal search I'm planning to start working on
this feature in parallel with RTL support. However, I have a concern about
how do you suggest to implement it?
I'm thinking that the relationship between a version and its languages is
one to many.
Something like:
'versions' => [ 'default' => '1.0', 'published' => [ '1.0' => [ 'en' => 'ltr', 'ar' => 'rtl' ], '1.1' => [ 'en' => 'ltr', ] ]],
what do you think guys?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMAaVk07sm3IPA-vKEJLm0w47RSe_yKgks5vLzRSgaJpZM4Zb_oJ>
.
|
Sounds simple now :D thank you @abhi-cognitivo |
Obviously implementing this feature will break a lot of existing usages (I mean it gonna be a major update) since the docs folder's structure will be changed. |
@saleem-hadad , language should be before version, as people don't change languages but can and will change versions quite often. But if you are going to do this, I would suggest applying both Version and Language as an optional feature, similar to what you do with Github Link or Search. Not every one will have multiple languages, and not every one will have multiple versions. Currently I am using version as language and it works great: Here is a screenshot: |
Any news on this features?? |
Hello there, I was going through my old tickets and I came across this one. Was wondering how far this is coming along. I'm writing a SaaS application and I'm nearing completion so I'm probably going to write some documentation for it. If this feature is still in development phase I might use @abhi-cognitivo 's idea to use versioning for translations. Thanks in advance for an update! |
will be added to the pro version as stated here |
Hello @saleem-hadad Are there any updates of implementing right to left? |
@hanifhefaz you can use this package for now |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
It's more a question then a feature request, but I had to choose and I'm definitely not reporting a bug.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I was wondering if it's possible to supply docs in multiple languages.
Additional context
Add any other context or screenshots about the feature request here.
I use this package for localization.
https://github.com/mcamara/laravel-localization
And this works with the following syntax
__('String to translate')
But I'm not sure if this will work in the .md files.
The text was updated successfully, but these errors were encountered: