From f83641603d91e9d20bb21931ae5a4ca2e4febc3c Mon Sep 17 00:00:00 2001 From: Peter Laird <921358+plaird@users.noreply.github.com> Date: Mon, 29 Jun 2020 18:22:24 -0600 Subject: [PATCH] stop cp refresh until perf issue fixed (#146) --- .../bazel/eclipse/builder/BazelBuilder.java | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/plugin-core/src/main/java/com/salesforce/bazel/eclipse/builder/BazelBuilder.java b/plugin-core/src/main/java/com/salesforce/bazel/eclipse/builder/BazelBuilder.java index 210fc1ad..198de5e9 100644 --- a/plugin-core/src/main/java/com/salesforce/bazel/eclipse/builder/BazelBuilder.java +++ b/plugin-core/src/main/java/com/salesforce/bazel/eclipse/builder/BazelBuilder.java @@ -91,7 +91,13 @@ protected IProject[] build(int kind, Map args, IProgressMonitor WorkProgressMonitor progressMonitor = new EclipseWorkProgressMonitor(monitor); IProject project = getProject(); progressMonitor.beginTask("Bazel build", 1); - + + // TODO there is something seriously wrong with Eclipse's resource change mechanism + // To be fixed in https://github.com/salesforce/bazel-eclipse/issues/145 + // We are getting FULL_BUILD commands even if files have not changed. + // See also the commented out line below for refreshProjectClasspath + //System.out.println(">> Eclipse signaled that project ["+project.getName()+"] is dirty with kind ["+kind+"]"); + BazelCommandManager bazelCommandManager = BazelPluginActivator.getBazelCommandManager(); JavaCoreHelper javaCoreHelper = BazelPluginActivator.getJavaCoreHelper(); BazelWorkspace bazelWorkspace = BazelPluginActivator.getBazelWorkspace(); @@ -114,7 +120,8 @@ protected IProject[] build(int kind, Map args, IProgressMonitor Set downstreamProjects = getDownstreamProjectsOf(project, allImportedProjects); buildProjects(bazelWorkspaceCmdRunner, downstreamProjects, progressMonitor, rootWorkspaceProject, monitor); - refreshProjectClasspath(project, progressMonitor, monitor, bazelWorkspaceCmdRunner); + // TODO this is too slow, we need to fix this in https://github.com/salesforce/bazel-eclipse/issues/145 + //refreshProjectClasspath(project, progressMonitor, monitor, bazelWorkspaceCmdRunner); } } catch (BazelCommandLineToolConfigurationException e) { LOG.error("Bazel not found: {} ", e.getMessage());