Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to include SKIP PR feature #303

Open
afalko opened this issue Feb 3, 2022 · 1 comment
Open

Update README to include SKIP PR feature #303

afalko opened this issue Feb 3, 2022 · 1 comment

Comments

@afalko
Copy link
Collaborator

afalko commented Feb 3, 2022

We forgot to update our README when we added this flag: https://github.com/salesforce/dockerfile-image-update/blob/master/dockerfile-image-update/src/main/java/com/salesforce/dockerfileimageupdate/subcommands/impl/Parent.java#L49

As extra credit, we should create a unit test that reminds us to update README.
CC: @avimanyum
@justinharringa
Copy link
Contributor

justinharringa commented Feb 3, 2022 •
edited
Loading

If we use labels properly (which we should/are) we could simply make sure that feature or enhancement PRs get a reminder poke in the PR. A vast majority of our PRs don't really introduce README-facing features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinharringa @afalko