Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix idempotency and code duplication in All / Parent #71

Open
justinharringa opened this issue Jun 3, 2019 · 0 comments
Open

Fix idempotency and code duplication in All / Parent #71

justinharringa opened this issue Jun 3, 2019 · 0 comments

Comments

@justinharringa
Copy link
Contributor

There is a fair amount of duplication and mutation of method arguments (typically MultiMaps) in Parent and All.

We should refactor out some of this to first-class objects to remove the duplication and move towards less mutation of inbound objects.

Example: All.forkRepositoriesFound(Multimap<String, String> pathToDockerfilesInParentRepo, Multimap<String, String> imagesFoundInParentRepo, Multimap<String, String> imagesFoundInParentRepo, PagedSearchIterable contentsWithImage, PagedSearchIterable contentsWithImage, String image) and Parent.forkRepositoriesFoundAndGetPathToDockerfiles(PagedSearchIterable contentsWithImage)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinharringa