Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excessive dependencies pulled by default nagios.nrpe.plugin formula #23

Open
cdarwin opened this issue Oct 14, 2015 · 12 comments
Open

Excessive dependencies pulled by default nagios.nrpe.plugin formula #23

cdarwin opened this issue Oct 14, 2015 · 12 comments

Comments

@cdarwin
Copy link

cdarwin commented Oct 14, 2015

This is from a fresh Debian wheezy installation:

----------
          ID: nrpe-plugin-package
    Function: pkg.installed
        Name: nagios-nrpe-plugin
      Result: True
     Comment: The following packages were installed/updated: nagios-nrpe-plugin
     Started: 13:35:49.296221
    Duration: 72255.574 ms
     Changes:
              ----------
              apache2:
                  ----------
                  new:
                      1
                  old:
              apache2-mpm:
                  ----------
                  new:
                      1
                  old:
              apache2-mpm-prefork:
                  ----------
                  new:
                      2.2.22-13+deb7u6
                  old:
              apache2-utils:
                  ----------
                  new:
                      2.2.22-13+deb7u6
                  old:
              apache2.2-bin:
                  ----------
                  new:
                      2.2.22-13+deb7u6
                  old:
              apache2.2-common:
                  ----------
                  new:
                      2.2.22-13+deb7u6
                  old:
              bind9-host:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              bsd-mailx:
                  ----------
                  new:
                      8.1.2-0.20111106cvs-1+deb7u1
                  old:
              default-mta:
                  ----------
                  new:
                      1
                  old:
              dnsutils:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              exim4-base:
                  ----------
                  new:
                      4.80-7+deb7u1
                  old:
              exim4-config:
                  ----------
                  new:
                      4.80-7+deb7u1
                  old:
              exim4-config-2:
                  ----------
                  new:
                      1
                  old:
              exim4-daemon-light:
                  ----------
                  new:
                      4.80-7+deb7u1
                  old:
              exim4-localscanapi-1.0:
                  ----------
                  new:
                      1
                  old:
              exim4-localscanapi-1.1:
                  ----------
                  new:
                      1
                  old:
              fping:
                  ----------
                  new:
                      3.2-1
                  old:
              freeipmi-common:
                  ----------
                  new:
                      1.1.5-3
                  old:
              freeipmi-tools:
                  ----------
                  new:
                      1.1.5-3
                  old:
              geoip-database:
                  ----------
                  new:
                      20130213-1
                  old:
              host:
                  ----------
                  new:
                      1
                  old:
              httpd:
                  ----------
                  new:
                      1
                  old:
              httpd-cgi:
                  ----------
                  new:
                      1
                  old:
              irb:
                  ----------
                  new:
                      1
                  old:
              irb1.9.1:
                  ----------
                  new:
                      1
                  old:
              javascript-common:
                  ----------
                  new:
                      7
                  old:
              libapache2-mod-php5:
                  ----------
                  new:
                      5.4.45-0+deb7u1
                  old:
              libapr1:
                  ----------
                  new:
                      1.4.6-3+deb7u1
                  old:
              libaprutil1:
                  ----------
                  new:
                      1.4.1-3
                  old:
              libaprutil1-dbd-sqlite3:
                  ----------
                  new:
                      1.4.1-3
                  old:
              libaprutil1-ldap:
                  ----------
                  new:
                      1.4.1-3
                  old:
              libbind9-80:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libclass-accessor-perl:
                  ----------
                  new:
                      0.34-1
                  old:
              libconfig-tiny-perl:
                  ----------
                  new:
                      2.14-1
                  old:
              libdate-manip-perl:
                  ----------
                  new:
                      6.32-1
                  old:
              libdbm-ruby1.9.1:
                  ----------
                  new:
                      1
                  old:
              libdigest-hmac-perl:
                  ----------
                  new:
                      1.03+dfsg-1
                  old:
              libdns88:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libencode-locale-perl:
                  ----------
                  new:
                      1.03-1
                  old:
              libfile-listing-perl:
                  ----------
                  new:
                      6.04-1
                  old:
              libfont-afm-perl:
                  ----------
                  new:
                      1.20-1
                  old:
              libfreeipmi12:
                  ----------
                  new:
                      1.1.5-3
                  old:
              libgd2:
                  ----------
                  new:
                      1
                  old:
              libgd2-noxpm:
                  ----------
                  new:
                      2.0.36~rc1~dfsg-6.1+deb7u1
                  old:
              libgdbm-ruby1.9.1:
                  ----------
                  new:
                      1
                  old:
              libgeoip1:
                  ----------
                  new:
                      1.4.8+dfsg-3
                  old:
              libhtml-form-perl:
                  ----------
                  new:
                      6.03-1
                  old:
              libhtml-format-perl:
                  ----------
                  new:
                      2.10-1
                  old:
              libhtml-parser-perl:
                  ----------
                  new:
                      3.69-2
                  old:
              libhtml-tagset-perl:
                  ----------
                  new:
                      3.20-2
                  old:
              libhtml-tree-perl:
                  ----------
                  new:
                      5.02-1
                  old:
              libhttp-cookies-perl:
                  ----------
                  new:
                      6.00-2
                  old:
              libhttp-daemon-perl:
                  ----------
                  new:
                      6.01-1
                  old:
              libhttp-date-perl:
                  ----------
                  new:
                      6.02-1
                  old:
              libhttp-message-perl:
                  ----------
                  new:
                      6.03-1
                  old:
              libhttp-negotiate-perl:
                  ----------
                  new:
                      6.00-2
                  old:
              libio-pty-perl:
                  ----------
                  new:
                      1:1.08-1+b2
                  old:
              libio-socket-ip-perl:
                  ----------
                  new:
                      0.16-2
                  old:
              libio-socket-ssl-perl:
                  ----------
                  new:
                      1.76-2
                  old:
              libio-tty-perl:
                  ----------
                  new:
                      1
                  old:
              libipc-run-perl:
                  ----------
                  new:
                      0.92-1
                  old:
              libipmiconsole2:
                  ----------
                  new:
                      1.1.5-3
                  old:
              libipmidetect0:
                  ----------
                  new:
                      1.1.5-3
                  old:
              libisc84:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libisccc80:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libisccfg82:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libjpeg8:
                  ----------
                  new:
                      8d-1+deb7u1
                  old:
              libjs-jquery:
                  ----------
                  new:
                      1.7.2+dfsg-1
                  old:
              liblockfile-bin:
                  ----------
                  new:
                      1.09-5
                  old:
              liblockfile1:
                  ----------
                  new:
                      1.09-5
                  old:
              liblwp-mediatypes-perl:
                  ----------
                  new:
                      6.02-1
                  old:
              liblwp-protocol-https-perl:
                  ----------
                  new:
                      6.03-1
                  old:
              liblwp-useragent-determined-perl:
                  ----------
                  new:
                      1.06-1
                  old:
              liblwres80:
                  ----------
                  new:
                      1:9.8.4.dfsg.P1-6+nmu2+deb7u7
                  old:
              libmail-imapclient-perl:
                  ----------
                  new:
                      3.31-2
                  old:
              libmail-perl:
                  ----------
                  new:
                      1
                  old:
              libmailtools-perl:
                  ----------
                  new:
                      2.09-1
                  old:
              libmath-calc-units-perl:
                  ----------
                  new:
                      1.07-1
                  old:
              libmemcached10:
                  ----------
                  new:
                      1.0.8-1
                  old:
              libmodule-implementation-perl:
                  ----------
                  new:
                      0.06-1
                  old:
              libmodule-runtime-perl:
                  ----------
                  new:
                      0.013-1
                  old:
              libmysqlclient18:
                  ----------
                  new:
                      5.5.44-0+deb7u1
                  old:
              libnagios-plugin-perl:
                  ----------
                  new:
                      0.36-1
                  old:
              libnet-dns-perl:
                  ----------
                  new:
                      0.66-2+b2
                  old:
              libnet-http-perl:
                  ----------
                  new:
                      6.03-2
                  old:
              libnet-ip-perl:
                  ----------
                  new:
                      1.25-3
                  old:
              libnet-libidn-perl:
                  ----------
                  new:
                      0.12.ds-1+b3
                  old:
              libnet-smtp-tls-perl:
                  ----------
                  new:
                      0.12-1
                  old:
              libnet-snmp-perl:
                  ----------
                  new:
                      6.0.1-2
                  old:
              libnet-ssleay-perl:
                  ----------
                  new:
                      1.48-1+b1
                  old:
              libonig2:
                  ----------
                  new:
                      5.9.1-1
                  old:
              libopenssl-ruby1.9.1:
                  ----------
                  new:
                      1
                  old:
              libparams-classify-perl:
                  ----------
                  new:
                      0.013-4
                  old:
              libparams-validate-perl:
                  ----------
                  new:
                      1.06-1
                  old:
              libparse-recdescent-perl:
                  ----------
                  new:
                      1.967009+dfsg-1
                  old:
              libperl5.14:
                  ----------
                  new:
                      5.14.2-21+deb7u2
                  old:
              libpng12-0:
                  ----------
                  new:
                      1.2.49-1
                  old:
              libpq5:
                  ----------
                  new:
                      9.1.18-0+deb7u1
                  old:
              libqdbm14:
                  ----------
                  new:
                      1.8.78-2
                  old:
              libradiusclient-ng2:
                  ----------
                  new:
                      0.5.6-1.1
                  old:
              libreadline-ruby1.9.1:
                  ----------
                  new:
                      1
                  old:
              libreadonly-perl:
                  ----------
                  new:
                      1.03-4
                  old:
              libreadonly-xs-perl:
                  ----------
                  new:
                      1.04-2+b3
                  old:
              libruby1.9.1:
                  ----------
                  new:
                      1.9.3.194-8.1+deb7u5
                  old:
              libsensors4:
                  ----------
                  new:
                      1:3.3.2-2+deb7u1
                  old:
              libsnmp-base:
                  ----------
                  new:
                      5.4.3~dfsg-2.8+deb7u1
                  old:
              libsnmp15:
                  ----------
                  new:
                      5.4.3~dfsg-2.8+deb7u1
                  old:
              libsocket-perl:
                  ----------
                  new:
                      2.002-1
                  old:
                      1
              libsub-name-perl:
                  ----------
                  new:
                      0.05-1+b2
                  old:
              libtalloc2:
                  ----------
                  new:
                      2.0.7+git20120207-1
                  old:
              libtdb1:
                  ----------
                  new:
                      1.2.10-2
                  old:
              libtry-tiny-perl:
                  ----------
                  new:
                      0.11-1
                  old:
              liburi-perl:
                  ----------
                  new:
                      1.60-1
                  old:
              libwbclient0:
                  ----------
                  new:
                      2:3.6.6-6+deb7u5
                  old:
              libwww-perl:
                  ----------
                  new:
                      6.04-1
                  old:
              libwww-robotrules-perl:
                  ----------
                  new:
                      6.01-1
                  old:
              libyaml-syck-perl:
                  ----------
                  new:
                      1.20-1
                  old:
              lsof:
                  ----------
                  new:
                      4.86+dfsg-1
                  old:
              mail-reader:
                  ----------
                  new:
                      1
                  old:
              mail-transport-agent:
                  ----------
                  new:
                      1
                  old:
              mailtools:
                  ----------
                  new:
                      1
                  old:
              mailx:
                  ----------
                  new:
                      1
                  old:
              mysql-common:
                  ----------
                  new:
                      5.5.44-0+deb7u1
                  old:
              nagios-images:
                  ----------
                  new:
                      0.7
                  old:
              nagios-nrpe-plugin:
                  ----------
                  new:
                      2.13-3
                  old:
              nagios-plugins:
                  ----------
                  new:
                      1.4.16-1
                  old:
              nagios-plugins-basic:
                  ----------
                  new:
                      1.4.16-1
                  old:
              nagios-plugins-common:
                  ----------
                  new:
                      1.4.16-1
                  old:
              nagios-plugins-contrib:
                  ----------
                  new:
                      4.20120702
                  old:
              nagios-plugins-standard:
                  ----------
                  new:
                      1.4.16-1
                  old:
              nagios3:
                  ----------
                  new:
                      3.4.1-3+deb7u1
                  old:
              nagios3-cgi:
                  ----------
                  new:
                      3.4.1-3+deb7u1
                  old:
              nagios3-common:
                  ----------
                  new:
                      3.4.1-3+deb7u1
                  old:
              nagios3-core:
                  ----------
                  new:
                      3.4.1-3+deb7u1
                  old:
              php5-cli:
                  ----------
                  new:
                      5.4.45-0+deb7u1
                  old:
              php5-common:
                  ----------
                  new:
                      5.4.45-0+deb7u1
                  old:
              php5-json:
                  ----------
                  new:
                      1
                  old:
              php5-mhash:
                  ----------
                  new:
                      1
                  old:
              phpapi-20100525:
                  ----------
                  new:
                      1
                  old:
              psmisc:
                  ----------
                  new:
                      22.19-1+deb7u1
                  old:
              qstat:
                  ----------
                  new:
                      2.11-3
                  old:
              rdoc:
                  ----------
                  new:
                      1
                  old:
              rdoc1.9.1:
                  ----------
                  new:
                      1
                  old:
              ruby:
                  ----------
                  new:
                      1:1.9.3
                  old:
              ruby-interpreter:
                  ----------
                  new:
                      1
                  old:
              ruby1.9.1:
                  ----------
                  new:
                      1.9.3.194-8.1+deb7u5
                  old:
              rubygems1.9.1:
                  ----------
                  new:
                      1
                  old:
              samba-client:
                  ----------
                  new:
                      1
                  old:
              samba-common:
                  ----------
                  new:
                      2:3.6.6-6+deb7u5
                  old:
              samba-common-bin:
                  ----------
                  new:
                      2:3.6.6-6+deb7u5
                  old:
              smbclient:
                  ----------
                  new:
                      2:3.6.6-6+deb7u5
                  old:
              snmp:
                  ----------
                  new:
                      5.4.3~dfsg-2.8+deb7u1
                  old:
              ssl-cert:
                  ----------
                  new:
                      1.0.32+deb7u1
                  old:
              whois:
                  ----------
                  new:
                      5.1.1~deb7u1
                  old:
              wwwconfig-common:
                  ----------
                  new:
                      0.2.2
                  old:

A colleague with more patience has informed me that "nagios-nrpe-plugin recommends nagios3 which deps nagios3-cgi which deps apache2-utils and recs apache2".

As a workaround, I have added the following to our infra:

states> cat core/nrpe_no_fucking_apache.sls
include:
  - base: nagios.nrpe.plugin

extend:
  nrpe-plugin-package:
    pkg.installed:
      - install_recommends: False
@gravyboat
Copy link
Contributor

Another fine issue created by nagios being garbage. I don't know how I feel about skipping install recommendations. Did you guys already report this issue to the nagios team? Seems like a failing where they should either provide two versions, or fix the deps.

@cdarwin
Copy link
Author

cdarwin commented Oct 14, 2015

That's a really good suggestion, but we haven't reached out to them directly at this time

@thenewwazoo
Copy link
Contributor

afaik apt installs recommended packages by default, unless you use --no-install-recommends; Recommended packages can be safely skipped (unless the package is broken). Perhaps no-recommends should also be the default behaviour in salt.

@gravyboat
Copy link
Contributor

Usually the recommends aren't a problem as far as I'm aware since they get all your deps installed (or at least it isn't a common issue I heard in the IRC/issues list). If you want to open an issue for discussion over on the main repo @thenewwazoo feel free! @cdarwin Alright, let me know what happens when you reach out to them.

@wwentland
Copy link
Contributor

@cdarwin This is a Debian packaging issue and has little to do with this formula (apart from maybe better support for setting --no-install-recommends).

That being said: Which dependency do you think is wrong and which set of packages did you expect to be installed with the NRPE plugin, which is, after all, the plugin that allows an NRPE server to execute Nagios plugins on a remote host. There's little need for this package on boxes that are not also running nagios or icinga. I therefore find it quite natural that nagios-nrpe-plugin recommends either icinga or nagios.

thenewwazoo pushed a commit to luciddg/nagios-formula that referenced this issue Oct 15, 2015
Clarify nagios, check_nrpe, nrpe-server, and plugins fixes saltstack-…
fac1eb0 
…formulas#23
@abednarik
Copy link
Contributor

Hi Guys

Just in case I did a small modification to avoid this ugly behavior Perceptyx#3

I can PR against this repo if you think it will help.

Cheers.

@aboe76
Copy link
Member

aboe76 commented Jul 6, 2018

@abednarik please make the PR

@abednarik
Copy link
Contributor

Hi @aboe76

Done in #63

Cheers.

@abednarik
Copy link
Contributor

@aboe76

Friendly reminder about above PR.

Thanks.

@aboe76
Copy link
Member

aboe76 commented Aug 31, 2018

@abednarik sorry for the late merge, :)

@abednarik
Copy link
Contributor

No problem, thanks!

@mgomersbach
Copy link
Contributor

solved by 538d569 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@wwentland @abednarik @cdarwin @gravyboat @thenewwazoo @aboe76 @mgomersbach