From e0eb72977694109051a6523c7192bf88685ec16f Mon Sep 17 00:00:00 2001
From: sictiru <sictiru@users.noreply.github.com>
Date: Tue, 17 Sep 2024 11:35:53 -0700
Subject: [PATCH] #1891 Handle Android 9 and below for OPML file export

---
 .../NewsBlur/app/src/main/AndroidManifest.xml | 215 +++++++++---------
 .../newsblur/activity/ImportExportActivity.kt |  34 ++-
 .../app/src/main/res/values/strings.xml       |   4 +-
 3 files changed, 149 insertions(+), 104 deletions(-)

diff --git a/clients/android/NewsBlur/app/src/main/AndroidManifest.xml b/clients/android/NewsBlur/app/src/main/AndroidManifest.xml
index 1f5645a034..f8dcce0211 100644
--- a/clients/android/NewsBlur/app/src/main/AndroidManifest.xml
+++ b/clients/android/NewsBlur/app/src/main/AndroidManifest.xml
@@ -1,22 +1,25 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:tools="http://schemas.android.com/tools"
-    xmlns:android="http://schemas.android.com/apk/res/android">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools">
 
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
     <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
     <uses-permission android:name="android.permission.WAKE_LOCK" />
-    <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
+    <uses-permission
+        android:name="android.permission.WRITE_EXTERNAL_STORAGE"
+        android:maxSdkVersion="28" />
 
     <application
-        android:icon="@drawable/logo"
-        android:label="@string/newsblur"
-        android:theme="@style/Theme.MaterialComponents.DayNight.NoActionBar"
-        android:fullBackupContent="@xml/backupscheme"
         android:name=".NbApplication"
-        android:dataExtractionRules="@xml/data_extraction_rules"
         android:allowBackup="true"
-        android:fullBackupOnly="true">
+        android:dataExtractionRules="@xml/data_extraction_rules"
+        android:fullBackupContent="@xml/backupscheme"
+        android:fullBackupOnly="true"
+        android:icon="@drawable/logo"
+        android:label="@string/newsblur"
+        android:theme="@style/Theme.MaterialComponents.DayNight.NoActionBar">
 
         <profileable
             android:shell="true"
@@ -24,15 +27,16 @@
 
         <activity
             android:name=".activity.InitActivity"
-            android:theme="@style/splashScreen"
+            android:exported="true"
             android:noHistory="true"
-            android:exported="true">
+            android:theme="@style/splashScreen">
             <intent-filter>
                 <category android:name="android.intent.category.LAUNCHER" />
                 <action android:name="android.intent.action.MAIN" />
             </intent-filter>
 
-            <meta-data android:name="android.app.shortcuts"
+            <meta-data
+                android:name="android.app.shortcuts"
                 android:resource="@xml/shortcuts" />
 
         </activity>
@@ -48,143 +52,139 @@
 
         <activity
             android:name=".activity.RegisterProgress"
-            android:noHistory="true"
-            android:label="@string/get_started" />
+            android:label="@string/get_started"
+            android:noHistory="true" />
 
         <activity
             android:name=".activity.Main"
-            android:launchMode="singleTask"
-            android:alwaysRetainTaskState="true" />
+            android:alwaysRetainTaskState="true"
+            android:launchMode="singleTask" />
 
         <activity
             android:name=".activity.Profile"
-            android:label="@string/profile"/>
+            android:label="@string/profile" />
 
         <activity
             android:name=".activity.Settings"
-            android:label="@string/settings"/>
+            android:label="@string/settings" />
 
         <activity android:name=".activity.ImportExportActivity" />
         <activity android:name=".activity.NotificationsActivity" />
         <activity
             android:name=".activity.WidgetConfig"
-            android:launchMode="singleTask"
-            android:label="@string/menu_widget" />
+            android:label="@string/menu_widget"
+            android:launchMode="singleTask" />
 
-        <activity
-            android:name=".activity.FeedItemsList" />
+        <activity android:name=".activity.FeedItemsList" />
 
         <activity
             android:name=".activity.AllStoriesItemsList"
-            android:launchMode="singleTask"/>
+            android:launchMode="singleTask" />
 
-        <activity
-            android:name=".activity.InfrequentItemsList" />
+        <activity android:name=".activity.InfrequentItemsList" />
 
-        <activity
-            android:name=".activity.ReadStoriesItemsList" />
+        <activity android:name=".activity.ReadStoriesItemsList" />
 
-        <activity
-            android:name=".activity.SavedStoriesItemsList" />
+        <activity android:name=".activity.SavedStoriesItemsList" />
 
-        <activity
-            android:name=".activity.AllSharedStoriesItemsList" />
+        <activity android:name=".activity.AllSharedStoriesItemsList" />
 
-        <activity
-            android:name=".activity.GlobalSharedStoriesItemsList" />
+        <activity android:name=".activity.GlobalSharedStoriesItemsList" />
 
-        <activity
-            android:name=".activity.FolderItemsList" />
+        <activity android:name=".activity.FolderItemsList" />
 
-        <activity
-            android:name=".activity.SocialFeedItemsList" />
+        <activity android:name=".activity.SocialFeedItemsList" />
 
-        <activity
-            android:name=".activity.FeedReading"/>
+        <activity android:name=".activity.FeedReading" />
 
-        <activity
-            android:name=".activity.AllStoriesReading"/>
+        <activity android:name=".activity.AllStoriesReading" />
 
-        <activity
-            android:name=".activity.InfrequentReading"/>
+        <activity android:name=".activity.InfrequentReading" />
 
-        <activity
-            android:name=".activity.ReadStoriesReading"/>
+        <activity android:name=".activity.ReadStoriesReading" />
 
-        <activity
-            android:name=".activity.SavedStoriesReading"/>
+        <activity android:name=".activity.SavedStoriesReading" />
 
-        <activity
-            android:name=".activity.AllSharedStoriesReading"/>
+        <activity android:name=".activity.AllSharedStoriesReading" />
 
-        <activity
-            android:name=".activity.GlobalSharedStoriesReading"/>
+        <activity android:name=".activity.GlobalSharedStoriesReading" />
 
-        <activity
-            android:name=".activity.FolderReading"/>
+        <activity android:name=".activity.FolderReading" />
 
-        <activity
-            android:name=".activity.SubscriptionActivity" />
+        <activity android:name=".activity.SubscriptionActivity" />
 
         <activity
             android:name=".activity.MuteConfig"
-            android:launchMode="singleTask"
-            android:label="@string/mute_sites"/>
+            android:label="@string/mute_sites"
+            android:launchMode="singleTask" />
 
         <activity
             android:name=".activity.FeedSearchActivity"
             android:launchMode="singleTop" />
 
-        <activity
-            android:name=".activity.SocialFeedReading"/>
+        <activity android:name=".activity.SocialFeedReading" />
 
         <service
             android:name=".service.NBSyncService"
             android:permission="android.permission.BIND_JOB_SERVICE" />
-        <service android:name=".widget.WidgetRemoteViewsService"
+        <service
+            android:name=".widget.WidgetRemoteViewsService"
             android:permission="android.permission.BIND_REMOTEVIEWS" />
         <service
             android:name=".service.SubscriptionSyncService"
-            android:permission="android.permission.BIND_JOB_SERVICE"
-            android:exported="false" />
+            android:exported="false"
+            android:permission="android.permission.BIND_JOB_SERVICE" />
 
-        <receiver android:name=".service.BootReceiver"
+        <receiver
+            android:name=".service.BootReceiver"
             android:exported="true">
             <intent-filter>
                 <action android:name="android.intent.action.BOOT_COMPLETED" />
             </intent-filter>
         </receiver>
 
-        <receiver android:name=".util.DownloadCompleteReceiver"
+        <receiver
+            android:name=".util.DownloadCompleteReceiver"
             android:exported="true">
             <intent-filter>
                 <action android:name="android.intent.action.DOWNLOAD_COMPLETE" />
             </intent-filter>
         </receiver>
 
-        <receiver android:name=".util.NotifyDismissReceiver" android:exported="false" />
-        <receiver android:name=".util.NotifySaveReceiver" android:exported="false" />
-        <receiver android:name=".util.NotifyMarkreadReceiver" android:exported="false" />
-        <receiver android:name=".util.NotifyShareReceiver" android:exported="false" />
-        <receiver android:name=".widget.WidgetProvider"
+        <receiver
+            android:name=".util.NotifyDismissReceiver"
+            android:exported="false" />
+        <receiver
+            android:name=".util.NotifySaveReceiver"
+            android:exported="false" />
+        <receiver
+            android:name=".util.NotifyMarkreadReceiver"
+            android:exported="false" />
+        <receiver
+            android:name=".util.NotifyShareReceiver"
+            android:exported="false" />
+        <receiver
+            android:name=".widget.WidgetProvider"
             android:exported="false">
             <intent-filter>
                 <action android:name="android.appwidget.action.APPWIDGET_UPDATE" />
             </intent-filter>
-            <meta-data android:name="android.appwidget.provider"
+            <meta-data
+                android:name="android.appwidget.provider"
                 android:resource="@xml/newsblur_appwidget_info" />
         </receiver>
-        <receiver android:name=".service.TimeChangeReceiver"
+        <receiver
+            android:name=".service.TimeChangeReceiver"
             android:exported="true">
-            <intent-filter >
-                <action android:name="android.intent.action.TIME_SET"/>
+            <intent-filter>
+                <action android:name="android.intent.action.TIME_SET" />
             </intent-filter>
         </receiver>
         <receiver
             android:name=".widget.WidgetUpdateReceiver"
             android:enabled="true"
-            android:exported="false">
-        </receiver>
+            android:exported="false"></receiver>
+
         <provider
             android:name="androidx.core.content.FileProvider"
             android:authorities="com.newsblur.fileprovider"
@@ -195,59 +195,70 @@
                 android:resource="@xml/file_paths" />
         </provider>
 
-        <activity android:name=".activity.AddFeedExternal"
+        <activity
+            android:name=".activity.AddFeedExternal"
             android:exported="true">
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
+
                 <category android:name="android.intent.category.DEFAULT" />
                 <category android:name="android.intent.category.BROWSABLE" />
-                <data android:scheme="http"/>
-                <data android:scheme="https"/>
-                <data android:host="*"/>
-                <data android:pathPattern=".*xml"/>
-                <data android:pathPattern=".*rss"/>
-                <data android:pathPattern=".*atom"/>
-                <data android:pathPattern=".*json"/>
-                <data android:pathPattern=".*/feed.*"/>
+
+                <data android:scheme="http" />
+                <data android:scheme="https" />
+                <data android:host="*" />
+                <data android:pathPattern=".*xml" />
+                <data android:pathPattern=".*rss" />
+                <data android:pathPattern=".*atom" />
+                <data android:pathPattern=".*json" />
+                <data android:pathPattern=".*/feed.*" />
             </intent-filter>
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
+
                 <category android:name="android.intent.category.DEFAULT" />
                 <category android:name="android.intent.category.BROWSABLE" />
+
                 <data android:scheme="feed" />
                 <data android:scheme="rss" />
             </intent-filter>
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
+
                 <category android:name="android.intent.category.DEFAULT" />
                 <category android:name="android.intent.category.BROWSABLE" />
-                <data android:scheme="http"/>
-                <data android:scheme="https"/>
-                <data android:host="feeds.feedburner.com"/>
-                <data android:host="feeds2.feedburner.com"/>
+
+                <data android:scheme="http" />
+                <data android:scheme="https" />
+                <data android:host="feeds.feedburner.com" />
+                <data android:host="feeds2.feedburner.com" />
             </intent-filter>
             <intent-filter>
-                <data android:scheme="http"/>
-                <data android:scheme="https"/>
+                <data android:scheme="http" />
+                <data android:scheme="https" />
+
                 <action android:name="android.intent.action.VIEW" />
+
                 <category android:name="android.intent.category.DEFAULT" />
                 <category android:name="android.intent.category.BROWSABLE" />
-                <data android:mimeType="text/xml"/>
-                <data android:mimeType="application/rss+xml"/>
-                <data android:mimeType="application/atom+xml"/>
-                <data android:mimeType="application/xml"/>
-                <data android:mimeType="application/json"/>
-                <data android:mimeType="application/feed+json"/>
-                <data android:scheme="http"/>
-                <data android:scheme="https"/>
+
+                <data android:mimeType="text/xml" />
+                <data android:mimeType="application/rss+xml" />
+                <data android:mimeType="application/atom+xml" />
+                <data android:mimeType="application/xml" />
+                <data android:mimeType="application/json" />
+                <data android:mimeType="application/feed+json" />
+                <data android:scheme="http" />
+                <data android:scheme="https" />
             </intent-filter>
         </activity>
 
-        <activity android:name=".activity.ShareExternalStoryActivity"
-            android:theme="@style/Theme.Translucent"
-            android:windowSoftInputMode="adjustResize"
+        <activity
+            android:name=".activity.ShareExternalStoryActivity"
+            android:exported="true"
             android:launchMode="singleInstance"
-            android:exported="true">
+            android:theme="@style/Theme.Translucent"
+            android:windowSoftInputMode="adjustResize">
             <intent-filter>
                 <action android:name="android.intent.action.SEND" />
                 <category android:name="android.intent.category.DEFAULT" />
diff --git a/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/ImportExportActivity.kt b/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/ImportExportActivity.kt
index 3f1b2c4c77..2c92973fd6 100644
--- a/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/ImportExportActivity.kt
+++ b/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/ImportExportActivity.kt
@@ -1,12 +1,16 @@
 package com.newsblur.activity
 
+import android.Manifest
 import android.app.Activity
 import android.content.Intent
+import android.content.pm.PackageManager
 import android.net.Uri
+import android.os.Build
 import android.os.Bundle
 import android.webkit.MimeTypeMap
 import android.widget.Toast
 import androidx.activity.result.contract.ActivityResultContracts
+import androidx.core.content.ContextCompat
 import com.google.android.material.snackbar.Snackbar
 import com.newsblur.R
 import com.newsblur.databinding.ActivityImportExportBinding
@@ -40,6 +44,16 @@ class ImportExportActivity : NbActivity() {
         }
     }
 
+    // used for Android 9 and below
+    private val requestWriteStoragePermissionLauncher = registerForActivityResult(
+            ActivityResultContracts.RequestPermission()) { isGranted ->
+        if (isGranted) {
+            exportOpmlFile()
+        } else {
+            Toast.makeText(this, R.string.write_storage_permission_opml, Toast.LENGTH_LONG).show()
+        }
+    }
+
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         binding = ActivityImportExportBinding.inflate(layoutInflater)
@@ -55,7 +69,13 @@ class ImportExportActivity : NbActivity() {
 
     private fun setupListeners() {
         binding.btnUpload.setOnClickListener { pickOpmlFile() }
-        binding.btnDownload.setOnClickListener { exportOpmlFile() }
+        binding.btnDownload.setOnClickListener {
+            if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.P) {
+                checkAndRequestWriteStoragePermission()
+            } else {
+                exportOpmlFile()
+            }
+        }
     }
 
     private fun pickOpmlFile() {
@@ -131,4 +151,16 @@ class ImportExportActivity : NbActivity() {
     override fun handleUpdate(updateType: Int) {
         // ignore
     }
+
+    // Android 9 and below
+    private fun checkAndRequestWriteStoragePermission() {
+        if (ContextCompat.checkSelfPermission(
+                        this,
+                        Manifest.permission.WRITE_EXTERNAL_STORAGE
+                ) == PackageManager.PERMISSION_GRANTED) {
+            exportOpmlFile()
+        } else {
+            requestWriteStoragePermissionLauncher.launch(Manifest.permission.WRITE_EXTERNAL_STORAGE)
+        }
+    }
 }
\ No newline at end of file
diff --git a/clients/android/NewsBlur/app/src/main/res/values/strings.xml b/clients/android/NewsBlur/app/src/main/res/values/strings.xml
index 6eda5fa25b..48387ba01c 100644
--- a/clients/android/NewsBlur/app/src/main/res/values/strings.xml
+++ b/clients/android/NewsBlur/app/src/main/res/values/strings.xml
@@ -745,7 +745,9 @@
 
     <string name="notification_permissions_context">Permissions is required for posting notifications</string>
     <string name="notification_permissions_rationale">Notifications permission must be added manually in the app\'s settings before trying again to enable notifications</string>
-    
+
+    <string name="write_storage_permission_opml">Write storage permission is required for OPML export</string>
+
     <string name="story_saved">Story marked as saved</string>
     <string name="story_unsaved">Story marked as unsaved</string>
     <string name="story_read">Story marked as read</string>