updated roles and company schema #139
Merged
+1,533
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
banushi-a
requested changes
Feb 21, 2025
packages/db/src/schema/companies.ts
Outdated
| }) satisfies z.ZodType< | ||
| Omit<typeof Company.$inferInsert, "id" | "createdAt" | "updatedAt"> | ||
| >; | ||
| averageHourlyPay: z.number(), |
There was a problem hiding this comment.
Ok so decimal in drizzle still means string lmao, so we have the zod schema would have to just require them to be strings. See this
So you will have to change the create_Schema for both role and company to have z.string() for whatever we mark as decimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the role and company schema to include averages for ratings and for pay.
Motivation and Context
Makes it so that we don't have to take a very long approach to find the average for things.
Closes #137
How has this been tested?
Screenshots (if appropriate):
Types of changes
pnpm db:generateand verified generated SQL migration files inpackages/db/drizzleChecklist: