#137 toggle task template #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arath7
reviewed
Feb 17, 2025
| batteryId: string, | ||
| visibility: string | ||
| ): APIResponse<ICustomizedBattery> => { | ||
| if (visibility !== "on" && visibility !== "off") { |
There was a problem hiding this comment.
left a similar comment on Armaan's PR #144 but I think it might be better if we do more graceful error handling here and default to visibility being off if we somehow reach these case because there isn't much the user will be able to do if they hit this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds visibility to ICustomizedBattery Schema. Created an endpoint to update the field based on the given status (on = true off = false)
Test Cases
updates battery to visible
updates battery to non visible
Screenshots
To Do
Closes #137