Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.hide MultiJvm configuration #48

Open
eed3si9n opened this issue Aug 1, 2018 · 0 comments
Open

.hide MultiJvm configuration #48

eed3si9n opened this issue Aug 1, 2018 · 0 comments

Comments

@eed3si9n
Copy link
Member

eed3si9n commented Aug 1, 2018

Akka's build contains a lot settings scoped to MultiJvm configuration, like formatting and header, but most subproject actually does not declare MultiJvm to be a configuration. When Akka upgrades to sbt 1.2.0, it will see a wall of warnings:

[warn] The project ProjectRef(uri("file:/Users/eed3si9n/work/akka/"), "akka-actor-typed") references an unknown configuration "multi-jvm" and was guessed to be "Multi-jvm".
[warn] This configuration should be explicitly added to the project.
[warn] The project ProjectRef(uri("file:/Users/eed3si9n/work/akka/"), "akka-actor-typed-tests") references an unknown configuration "multi-jvm" and was guessed to be "Multi-jvm".
[warn] This configuration should be explicitly added to the project.
[warn] The project ProjectRef(uri("file:/Users/eed3si9n/work/akka/"), "akka") references an unknown configuration "multi-jvm" and was guessed to be "Multi-jvm".
[warn] This configuration should be explicitly added to the project.
[warn] The project ProjectRef(uri("file:/Users/eed3si9n/work/akka/"), "akka-stream-tests-tck") references an unknown configuration "multi-jvm" and was guessed to be "Multi-jvm".
[warn] This configuration should be explicitly added to the project.
[warn] The project ProjectRef(uri("file:/Users/eed3si9n/work/akka/"), "akka-osgi") references an unknown configuration "multi-jvm" and was guessed to be "Multi-jvm".
[warn] This configuration should be explicitly added to the project.
[warn] The project ProjectRef(uri("file:/Users/eed3si9n/work/akka/"), "akka-protobuf") references an unknown configuration "multi-jvm" and was guessed to be "Multi-jvm".
[warn] This configuration should be explicitly added to the project.
[warn] The project ProjectRef(uri("file:/Users/eed3si9n/work/akka/"), "akka-actor-testkit-typed") references an unknown configuration "multi-jvm" and was guessed to be "Multi-jvm".
[warn] This configuration should be explicitly added to the project.
...

One way to prevent this is to inject the configuration to all subprojects via a local AutoPlugin, but to make sure that the configuration does not leak out to POM etc, it should probably declare itself as private by calling .hide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant