Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started guide paragraph "Types for Tasks and Settings" is unclear #354

Open
prokopowicz opened this issue Apr 26, 2017 · 1 comment

Comments

@prokopowicz
Copy link

prokopowicz commented Apr 26, 2017

  1. what is meant by the example "taskKey := 42" ? Is taskKey the name of some TaskKey? If so it should be called someTaskKey or aTaskKey. same for settingKey. Otherwise it conflicts in the reader's mind with the creation method taskKey.

  2. The assignment someTaskKey := 42 doesn't work cleanly. You get a warning:
    "a pure expression does nothing in statement position; you may be omitting necessary parentheses" this example should work cleanly.

  3. "From a type-system perspective, the Setting created from a task key is slightly different from the one created from a setting key." The notion that a Setting is created from a task key has not been discussed at all. When is the Setting created? Why do setting keys and task keys both create Settings?

@eed3si9n
Copy link
Member

Thanks for the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants