Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from setup.py to pyproject.toml #512

Open
Valentin-Laurent opened this issue Sep 6, 2024 · 0 comments
Open

Switch from setup.py to pyproject.toml #512

Valentin-Laurent opened this issue Sep 6, 2024 · 0 comments
Labels
Backlog This is in the MAPIE team development backlog, yet to be prioritised. Contributors welcome 👋🏻 Especially relevant issue/PR for contributors to work on. Other or internal If no other grey tag is relevant or if issue from the MAPIE team

Comments

@Valentin-Laurent
Copy link
Collaborator

Valentin-Laurent commented Sep 6, 2024

Context
MAPIE is using setuptools (with setup.py) to build its distribution. This will soon have consequences, as pip 25.0 will enforce more modern tooling.

We should switch to pyproject.toml. This ressource may be interesting.

Describe the bug
For example, installing MAPIE 0.9 in dev mode throws a pip deprecation warning.

To Reproduce
Clone the repo then run pip install -e .

Stacktrace

DEPRECATION: Legacy editable install of MAPIE==0.9.0 from file:///Users/vlaurent/code/pro/MAPIE/MAPIE (setup.py develop) is deprecated. pip 25.0 will enforce this behaviour change. A possible replacement is to add a pyproject.toml or enable --use-pep517, and use setuptools >= 64. If the resulting installation is not behaving as expected, try using --config-settings editable_mode=compat. Please consult the setuptools documentation for more information. Discussion can be found at https://github.com/pypa/pip/issues/11457
  Running setup.py develop for MAPIE
Successfully installed MAPIE-0.9.0

Additional info
I got this email when uploading MAPIE to TestPyPi:

In the future, PyPI will require all newly uploaded source distribution filenames to comply with PEP 625. Any source distributions already uploaded will remain in place as-is and do not need to be updated.

Specifically, your recent upload of 'MAPIE-1.0.0a1.tar.gz' is incompatible with PEP 625 because it does not contain the normalized project name 'mapie'.

In most cases, this can be resolved by upgrading the version of your build tooling to a later version that supports PEP 625 and produces compliant filenames.

@Valentin-Laurent Valentin-Laurent added Status: discussion ended Needs decision The MAPIE team is deciding what to do next. labels Oct 16, 2024
@jawadhussein462 jawadhussein462 added Backlog This is in the MAPIE team development backlog, yet to be prioritised. and removed Needs decision The MAPIE team is deciding what to do next. labels Nov 5, 2024
@Valentin-Laurent Valentin-Laurent added the Other or internal If no other grey tag is relevant or if issue from the MAPIE team label Nov 18, 2024
@Valentin-Laurent Valentin-Laurent added Contributors welcome 👋🏻 Especially relevant issue/PR for contributors to work on. and removed Bug labels Jan 9, 2025
@Valentin-Laurent Valentin-Laurent changed the title Installing MAPIE 0.9 in dev mode throws a pip deprecation warning Switch from setup.py to pyproject.toml Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog This is in the MAPIE team development backlog, yet to be prioritised. Contributors welcome 👋🏻 Especially relevant issue/PR for contributors to work on. Other or internal If no other grey tag is relevant or if issue from the MAPIE team
Projects
None yet
Development

No branches or pull requests

2 participants