Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme to make releases possible #24

Closed
flying-sheep opened this issue Mar 14, 2024 · 3 comments · Fixed by #25
Closed

Fix readme to make releases possible #24

flying-sheep opened this issue Mar 14, 2024 · 3 comments · Fixed by #25

Comments

@flying-sheep
Copy link
Collaborator

flying-sheep commented Mar 14, 2024

The release workflows currently fail with

 Checking dist/sklearn_ann-0.1.1-py3-none-any.whl: FAILED
ERROR    `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.          

https://github.com/scikit-learn-contrib/sklearn-ann/actions/runs/8285153041/job/22672248085

maybe we simply missed adding readme = "README.rst" in pyproject.toml?

@flying-sheep
Copy link
Collaborator Author

flying-sheep commented Mar 14, 2024

Fixed in #25! It’s now published https://pypi.org/project/sklearn-ann/

@frankier if you tell me you PyPI name, I can add you as maintainer

@flying-sheep flying-sheep linked a pull request Mar 14, 2024 that will close this issue
@frankier
Copy link
Collaborator

Great! It's frankier.

Thanks for the continued poking and pushing all this through.

@flying-sheep
Copy link
Collaborator Author

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants