Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame unwrapping documentation typo? #518

Open
g5t opened this issue May 27, 2024 · 0 comments
Open

Frame unwrapping documentation typo? #518

g5t opened this issue May 27, 2024 · 0 comments

Comments

@g5t
Copy link

g5t commented May 27, 2024

To compute the time-of-flight we first add an integer multiple of the frame length to event_time_offset (and subtract the equivalent from event_time_zero).

https://github.com/scipp/scippneutron/blob/d2237f7abcb52a74e1e3bef0df462c21e95c887d/docs/api-reference/frame-unwrapping.ipynb#L80C113-L80C163

Should the parenthetical read, "or subtract the equivalent from event_time_zero"?
That is, the actual time of flight is $$t = N \Delta T + \Delta t - T_0 = \Delta t - (T_0 - N \Delta T)$$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant