Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DCExecutionProfileTest #22

Open
dkropachev opened this issue Nov 14, 2024 · 2 comments
Open

Fix DCExecutionProfileTest #22

dkropachev opened this issue Nov 14, 2024 · 2 comments

Comments

@dkropachev
Copy link
Collaborator

Right now it is failing on master due to the LWT and tablets conflict:

/jenkins/workspace/scylla-master/driver-tests/cpp-driver-matrix-test/cpp-driver-scylla/tests/src/integration/objects/future.hpp:152
      Expected: CASS_OK
To be equal to: wait_code
      Which is: CASS_ERROR_SERVER_INVALID_QUERY [Invalid query]
Invalid query: Cannot use LightWeight Transactions for table dcexecutionprofile_blacklistdcfiltering.cassandra_blacklistdcfiltering: LWT is not yet supported with tablets

Run example: https://jenkins.scylladb.com/view/master/job/scylla-master/job/driver-tests/job/cpp-driver-matrix-test/1203/

@muzarski
Copy link

@dkropachev I have a question. Assuming I fixed the tests. What are my next steps?

From our yesterday's discussion, I remembered that I need to apply a patch for an upstream (i.e. in version/datastax/ directory). Do I do the same for scylla (version/scylla directory)? And most importantly, do I open a PR in https://github.com/scylladb/cpp-driver that fixes the tests?

I'm asking this, because AFAIU, only 2 last release versions of the driver are tested. This means if I only merge the changes to master of cpp-driver, these will not be visible in the test (since they are yet to be released). But I might be talking gibberish, so correct me if I'm wrong.

@dkropachev
Copy link
Collaborator Author

@dkropachev I have a question. Assuming I fixed the tests. What are my next steps?

From our yesterday's discussion, I remembered that I need to apply a patch for an upstream (i.e. in version/datastax/ directory). Do I do the same for scylla (version/scylla directory)? And most importantly, do I open a PR in https://github.com/scylladb/cpp-driver that fixes the tests?

We discussed it briefly, for scylladb/cpp-driver you fix it on master, if it is appropriate, to make next version work properly and put the same fix into versions/scylla to a folder that makes sense.
If you know when it is broken pick right version.
If there is already folders for affected versions, you need to update all of them.
if version where it become broken is not there, create it copying folder for closest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants