Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raft read barrier API is not a part of 2024.2 #4183

Closed
Michal-Leszczynski opened this issue Dec 19, 2024 · 2 comments · Fixed by #4185
Closed

Raft read barrier API is not a part of 2024.2 #4183

Michal-Leszczynski opened this issue Dec 19, 2024 · 2 comments · Fixed by #4185
Assignees
Labels
bug Something isn't working high

Comments

@Michal-Leszczynski
Copy link
Collaborator

Recently #3932 was fixed. It assumed that the raft read barrier API will be a part of the 2024.2 release, but that's not the case.
When running SCT against Scylla 2024.2 we get HTTP 404 when querying non-existence Scylla API:

{"L":"INFO","T":"2024-12-19T10:25:02.913Z","N":"scheduler.802de8bc","M":"Run ended with ERROR","task":"backup/332266ee-ef54-4a08-ba17-e7c50fc833f8","status":"ERROR","cause":"await schema: perform raft read barrier on desc schema host: RaftReadBarrierPost: agent [HTTP 404] Not found","duration":"7.766091055s","_trace_id":"fCrMJMEWSgCEBHZme-gVuQ"}

Unfortunately, because of scylladb/scylladb#16424, we need rely on version checks, so there is no way around it.
We could try to make empirically check if Scylla exposes given API endpoint by checking for HTTP 404 status code, but this probably wouldn't be really robust.

@Michal-Leszczynski Michal-Leszczynski added bug Something isn't working high labels Dec 19, 2024
@Michal-Leszczynski Michal-Leszczynski self-assigned this Dec 20, 2024
Michal-Leszczynski added a commit that referenced this issue Dec 20, 2024
It turns out that Scylla 2024.2 does not expose this API.
For now, it's not know which enterprise release will contain it.
Fixes #4183
Michal-Leszczynski added a commit that referenced this issue Dec 20, 2024
It turns out that Scylla 2024.2 does not expose this API.
For now, it's not know which enterprise release will contain it,
so we need to fall back to the CQL workaround.

Fixes #4183
@mykaul
Copy link
Contributor

mykaul commented Dec 25, 2024

Did you ask for a backport of scylladb/scylladb#19597 ? Perhaps it's easily doable.

@Michal-Leszczynski
Copy link
Collaborator Author

I wouldn't say that we need to backport it, as we have another way issuing raft read barrier that was used before.
Also, it's a feature, not a fix.

The general problem is that the only way for SM to check if given Scylla version supports some feature is by version checking. This sometimes gets messy with temporary versions used for testing (e.g. build from master which identifies with 2024.2.X-Y-Z version contains given feature, but the actual 2024.2.0 release does not).

In the context of this issue, for some reason I thought that 2024.2 is based on 6.1 (which contains the new API), but it is based on 6.0 (which does not include it).

Michal-Leszczynski added a commit that referenced this issue Jan 7, 2025
…#4185)

It turns out that Scylla 2024.2 does not expose this API.
For now, it's not know which enterprise release will contain it,
so we need to fall back to the CQL workaround.

Fixes #4183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants