Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between highlight and selection not apparent for editor focus. Is this from the theme or VScode? #252

Open
Santosh-Gupta opened this issue Mar 21, 2020 · 1 comment

Comments

@Santosh-Gupta
Copy link

Santosh-Gupta commented Mar 21, 2020

first

the 'cache' at the top is selected, the one at the bottom is highlighted because all instances of 'cache' are highlighted when one is selected.

The difference between highlighted and selected if tricky to detect. If I click off the editor space, the difference gets a little better.

second

Here's another example where the cursor is at a word, and it's highlighted, but the word itself is Not selected

third

And the one below is with the cursor is at the word, And the word itself is selected

fourth

Again, it gets a little better when clicked off the editing space

fourth

At first I thought it was the Night Owl theme, but I tried different themes, and the difference between selection and highlight is still not very apparent in any of the themes. But I see screens/gifs of other vscode setups, and the differences seem to be stronger.

So I am wonder if this is from the theme, or something else going on in vscode.

Edit:

I did some googling in case this was a vscode issue. This seemed to be an issue in general back in 2017, I can't tell if these are still relevant

microsoft/vscode#34105

microsoft/vscode#24034

@Santosh-Gupta
Copy link
Author

Santosh-Gupta commented Mar 22, 2020

So far, I put this in my user setting, which is working decently.

"workbench.colorCustomizations": {
"editor.selectionBackground": "#4d057b" //Current selected text
}

fourth

The color is from Amethyst's editor.selectionBackground color.

https://github.com/eamodio/vscode-amethyst-theme/blob/master/themes/amethyst-theme.json#L39

I tried to pick one that doesn't look 'dusty', which is what 99% of dark color themes look like to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant