Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Version 2.1.0, Light] - changes to braces colors makes some braces hard to see #331

Closed
orept opened this issue Dec 29, 2024 · 8 comments
Closed

Comments

@orept
Copy link

orept commented Dec 29, 2024

2.0.2: (Normal)
night-owl-pre-2 1

2.1.0: (Bad)
night-owl-2 1-bad-color

Looks like it's 222ca7c commit

@CastaChick
Copy link

The current color (#87fab73a) has a contrast ratio of nearly 1, which is too low.
To match the colors from versions prior to 2.1.0, I think #733c1d would be a good choice.
It has a contrast ratio of over 7, making it sufficiently visible for individuals with colorblind as well.

@coollugi
Copy link

CleanShot 2024-12-29 at 20 21 56@2x

Also have smilier issue, maybe a bit brighter in dark theme?

@JohnPiepersSmits
Copy link

JohnPiepersSmits commented Dec 29, 2024

Also have similar issue, maybe a bit brighter in dark theme?

Like coollugi: I see the same thing too in the dark theme, and have reverted back to the 2.0.2 version of Night Owl for the time being.

John

@latuprez
Copy link

latuprez commented Dec 30, 2024

Yeah I'm also seeing the dark gray brackets now in the dark theme and I find it really tough to see and parse. Going to try reverting to an older version

@sebbean
Copy link

sebbean commented Dec 30, 2024

also seeing this ya'll!

hi mom

@nikunj-26
Copy link

The bracket colors looked super weird in the dark theme! Reverted back to v2.0.2. Imo the color scheme for brackets in v2.0.2 is perfect

@ATLCode
Copy link

ATLCode commented Dec 31, 2024

Glad to see I wasn't the only one. With dark theme some parantheses looked grey that was very hard to see.

Reverted to 2.0.2 version like John suggested for now, but obviously this is something that should get fixed when possible.

@sdras
Copy link
Owner

sdras commented Dec 31, 2024

Should be all fixed! Please feel free to reopen if I'm mistaken. Happy new years.

@sdras sdras closed this as completed Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants