Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjusted color of bracket highlight in light theme #332

Closed
wants to merge 1 commit into from
Closed

fix: Adjusted color of bracket highlight in light theme #332

wants to merge 1 commit into from
+2 −3

Conversation

CastaChick
Copy link

close #331

Starting from version 2.1.0, the contrast ratio of bracket highlights in light mode was lowered. We have adjusted this to match the display style of version 2.0.2.

version screenshot
ver 2.0.2 2.0.2
ver 2.1.0 2.1.0
My suggestion after

@sdras
Copy link
Owner

sdras commented Dec 30, 2024

Someone else mentioned this to me- I'll look into it soon

@sdras
Copy link
Owner

sdras commented Dec 30, 2024

Actually, a little confused by your post above- in your suggestion screenshot, it looks the same as 2.1.0? What am I missing?

@CastaChick
Copy link
Author

CastaChick commented Dec 30, 2024 •
edited
Loading

@sdras Apologies for the confusion.
As you can see in the enlarged images below, it seems that the brackets have become almost invisible in version 2.1.0.
They are enlarged images of the part on the 4th line of the screenshot above.

version screenshot
ver 2.0.2 2.0.2
ver 2.1.0 2.1.0
My suggestion after

@abn5x
Copy link

abn5x commented Dec 30, 2024

I have the same issue. Almost invisible for me too..

matthewpizza added a commit to matthewpizza/dotfiles that referenced this pull request Dec 30, 2024
@matthewpizza
My poor eyes
ddb037c 
sdras/night-owl-vscode-theme#332
@sdras
Copy link
Owner

sdras commented Dec 31, 2024

Ah I see, thank you! I may revert the change from the last version rather than taking the PR because I've heard dark mode broke too, I'll get this in today

@CastaChick
Copy link
Author

Thank you for reply. It would be better to revert the commit.
So, I will close this PR.
Have a great New Year✨

@CastaChick CastaChick closed this Dec 31, 2024
@sdras
Copy link
Owner

sdras commented Dec 31, 2024

Thank you so much for this! This should be resolved now- I just published, might take an hour or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Version 2.1.0, Light] - changes to braces colors makes some braces hard to see
3 participants
@CastaChick @sdras @abn5x