Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directed graph generation failed for yaml format #93

Open
metiroozmeh opened this issue Apr 28, 2021 · 3 comments
Open

Directed graph generation failed for yaml format #93

metiroozmeh opened this issue Apr 28, 2021 · 3 comments

Comments

@metiroozmeh
Copy link

Description

The generated graph in yaml format is not a DAG graph, however, during configuration phase directed option is chosen. Please let me know if there is a solution to this issue. Please have a look at the generated file using the link below :

https://drive.google.com/file/d/1o2WODs34h2pwAeOgItcmTgjxT6mA0zjD/view?usp=sharing

You can find the loop in these nodes: [[4, 7, 10], [1, 5, 9]]

Expected Behavior

Directed acyclic graph

Actual Behavior

Looped graph

Operating System

Linux

Python Version

PYthon 3.7.5

Pyrgg Version

V1.0

@sepandhaghighi
Copy link
Owner

sepandhaghighi commented Apr 29, 2021

@metiroozmeh
Thanks for your comment 💯
The graph you mentioned above can be directed but is not acyclic.
Unfortunately, in this version of pyrgg there is no option to control cycles!
We will add this option in a future release.
Please, feel free to let me know if you require any further information.

@metiroozmeh
Copy link
Author

@sepandhaghighi
Thank you for your quick reply and well-organized repository. I missed the point that the graphs are directed but cyclic since I am looking for DAG generator in C/C++ or python preferably. Do you have any suggestion ? Hopefully the next pyrgg version will be equipped with this feature which to me is more than essential .

@sepandhaghighi
Copy link
Owner

sepandhaghighi commented Apr 29, 2021

@sepandhaghighi
Thank you for your quick reply and well-organized repository. I missed the point that the graphs are directed but cyclic since I am looking for DAG generator in C/C++ or python preferably. Do you have any suggestion ? Hopefully the next pyrgg version will be equipped with this feature which to me is more than essential .

@metiroozmeh
🙏🙏

  1. I'm not sure, but take a look at networkx
  2. If you need some small~medium graphs, you can use pyrgg version 1.0 and remove cycles manually

You are completely right, this option is necessary and I plan to add it in the next few weeks (probably version 1.2).
If you like this project, you can support it by giving us a ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants