Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New dialects in sequelize 6.x break the ts build in sequelize-auto #641

Open
hhowe29 opened this issue Mar 11, 2023 · 0 comments · Fixed by hhowe29/sequelize-auto#2 · May be fixed by #642
Open

New dialects in sequelize 6.x break the ts build in sequelize-auto #641

hhowe29 opened this issue Mar 11, 2023 · 0 comments · Fixed by hhowe29/sequelize-auto#2 · May be fixed by #642

Comments

@hhowe29
Copy link

hhowe29 commented Mar 11, 2023

On 03/11/23, a fresh clone of the repo fails to build with this error

$ npm run tsc

> [email protected] tsc
> tsc

src/dialects/dialects.ts:8:14 - error TS2739: Type 
'{ mssql: DialectOptions; mysql: DialectOptions; mariadb: DialectOptions; postgres: DialectOptions; sqlite: DialectOptions; }' 
is missing the following properties from type <snipped> : db2, snowflake, oracle

8 export const dialects: { [name in Dialect]: DialectOptions } = {

npm list sequelize shows that I pulled in 6.29.3
hhowe29 added a commit to hhowe29/sequelize-auto that referenced this issue Mar 11, 2023
@hhowe29
Added missing dialects to fix ts compile with sequelize 6.29. Fixes s…
57273ab 
…equelize#641.
@hhowe29 hhowe29 linked a pull request Mar 11, 2023 that will close this issue
Open
hhowe29 added a commit to hhowe29/sequelize-auto that referenced this issue Mar 11, 2023
@hhowe29
Added missing dialects to fix ts compile with sequelize 6.29. Fixes s…
38668a0 
…equelize#641.
@hhowe29 hhowe29 mentioned this issue Mar 14, 2023
Merged
@hhowe29 hhowe29 reopened this Apr 3, 2023
9renpoto pushed a commit to 9renpoto/sequelize-auto that referenced this issue Dec 8, 2023
@hhowe29 @9renpoto
Added missing dialects to fix ts compile with sequelize 6.29. Fixes s…
8dd3537 
…equelize#641.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@hhowe29