Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - add customMaskingOperator option to items in maskProperties list. #29

Open
mistyn8 opened this issue Mar 28, 2023 · 3 comments

Comments

@mistyn8
Copy link

mistyn8 commented Mar 28, 2023

Thought it would be a good idea, to say

options.MaskProperties.Add("_Password", PasswordMaskingOperator);

That way we can have the same extensiblity to say leave first and last char exposed?

Or maybe extending on the mask, rather than just a simple replace have some options?
options.MaskProperties.Add("_Password", new maskoptions {showFirst:2, showLast:2, preservelenght:true)});

(I admit taking inspiration from https://github.com/destructurama/attributed/blob/dev/src/Destructurama.Attributed/Attributed/LogMaskedAttribute.cs)

@IMCubator-CI
Copy link

100% agree

sandermvanvliet added a commit that referenced this issue Jan 7, 2024
@sandermvanvliet
Copy link
Contributor

I've taken a stab at this, have a look at WhenMaskingWithOptions.cs for how this will work.

There is a problem that this currently breaks the JSON configuration capabilities so this might change.

@maksimnarkevichdp
Copy link

maksimnarkevichdp commented Nov 22, 2024

Hey, is there any progress on this? I see the PR was merged, but package was not published yet. Would certainly like to see this released asap. How can I help?

@sandermvanvliet do you have any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants