Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatability with ComfyUI_frontend v1.2.48 #318

Closed
christian-byrne opened this issue Sep 9, 2024 · 1 comment
Closed

Compatability with ComfyUI_frontend v1.2.48 #318

christian-byrne opened this issue Sep 9, 2024 · 1 comment

Comments

@christian-byrne
Copy link

In ComfyUI_frontend v1.2.48, this line:

comfyui-mixlab-nodes/web/javascript/td_background.js

Line 62 in 67b4ec3

ctx.setTransform(1, 0, 0, 1, 0, 0)

Was changed to:

ctx.setTransform(window.devicePixelRatio, 0, 0, window.devicePixelRatio, 0, 0)

See: Comfy-Org/litegraph.js#116

Scale was also applied to drawFrontCanvas. So when comfyui-mixlab-nodes and ComfyUI_frontend v1.2.48^ are installed together, the front and back canvas receive different scale factors.

Issue:
@christian-byrne christian-byrne mentioned this issue Sep 18, 2024
Closed
@christian-byrne
Copy link
Author

Fixed by d9edbd5

@niknah niknah mentioned this issue Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@christian-byrne