From 9da6f53c2f92ddf63249385b9c35ab2c96a9d6de Mon Sep 17 00:00:00 2001 From: Joey Parrish Date: Wed, 8 May 2024 08:18:58 -0700 Subject: [PATCH] fix(shaka-lab-node): Do not require optional parameters (#51) In #50, I forgot to mark all the newly-added parameters as optional, which broke some nodes in the lab. --- shaka-lab-node/node-templates.yaml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/shaka-lab-node/node-templates.yaml b/shaka-lab-node/node-templates.yaml index c3350f5..1bb1d0b 100644 --- a/shaka-lab-node/node-templates.yaml +++ b/shaka-lab-node/node-templates.yaml @@ -58,8 +58,8 @@ chromecast: params: - hostname - version - - receiver-app-id - - idle-timeout-seconds + - ?receiver-app-id # optional + - ?idle-timeout-seconds # optional defs: genericwebdriver.browser.name: chromecast genericwebdriver.backend.exe: node_modules/.bin/chromecast-webdriver-server$cmd @@ -77,10 +77,10 @@ chromeos: params: - hostname - version - - username - - private-key - - fetch-private-key - - private-key-url + - ?username # optional + - ?private-key # optional + - ?fetch-private-key # optional + - ?private-key-url # optional defs: genericwebdriver.browser.name: chromeos genericwebdriver.backend.exe: node_modules/.bin/chromeos-webdriver-server$cmd @@ -100,10 +100,10 @@ tizen: - hostname - ?ethaddr # optional - version - - local-tizen-studio - - tizen-studio-docker-image - - tizen-studio-path - - tizen-studio-author-profile + - ?local-tizen-studio # optional + - ?tizen-studio-docker-image # optional + - ?tizen-studio-path # optional + - ?tizen-studio-author-profile # optional defs: genericwebdriver.browser.name: tizen genericwebdriver.backend.exe: node_modules/.bin/tizen-webdriver-server$cmd