Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Offline): Allow downloading some clearkey content without persistent license support #7811

Merged
merged 5 commits into from
Dec 31, 2024
Merged

feat(Offline): Allow downloading some clearkey content without persistent license support #7811

merged 5 commits into from
Dec 31, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 27, 2024

Cases:

  • Configured drm.clearKeys
  • HLS SAMPLE-AES

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: offline The issue involves the offline storage system of Shaka Player labels Dec 27, 2024
@avelad avelad added this to the v4.13 milestone Dec 27, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Dec 27, 2024 •
edited
Loading

Incremental code coverage: 90.00%

theodab
theodab requested changes Dec 28, 2024
View reviewed changes
lib/offline/storage.js Outdated Show resolved Hide resolved
lib/drm/drm_engine.js Outdated Show resolved Hide resolved
@theodab theodab changed the title feat(Offline): Allow download some clearkey content without persistent license support feat(Offline): Allow downloading some clearkey content without persistent license support Dec 30, 2024
theodab
theodab approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part.

lib/drm/drm_engine.js Outdated Show resolved Hide resolved
@avelad
Copy link
Member Author

avelad commented Dec 31, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7811

@avelad avelad merged commit 50a1851 into shaka-project:main Dec 31, 2024
31 of 32 checks passed
@avelad avelad deleted the clearkey-download branch December 31, 2024 14:52
@shaka-bot shaka-bot mentioned this pull request Dec 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@tykus160 tykus160 Awaiting requested review from tykus160

Assignees
No one assigned
Labels
component: offline The issue involves the offline storage system of Shaka Player priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab