Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Offline): Allow downloading AES content #7827

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 3, 2025

Also adds integration tests for DASH AES-128, HLS AES-256 and HLS SAMPLE-AES download and playback

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: offline The issue involves the offline storage system of Shaka Player labels Jan 3, 2025
@avelad avelad added this to the v4.13 milestone Jan 3, 2025
@avelad
Copy link
Member Author

avelad commented Jan 3, 2025

@shaka-bot test

@avelad avelad changed the title fix(Offline): Allow downloading HLS AES-128 content fix(Offline): Allow downloading HLS AES content Jan 3, 2025
@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7827

@avelad avelad force-pushed the store-aes-sample-aes branch from d6e8419 to f392ab1 Compare January 3, 2025 12:23
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad force-pushed the store-aes-sample-aes branch from f392ab1 to 4dbd2ff Compare January 3, 2025 13:10
@avelad avelad changed the title fix(Offline): Allow downloading HLS AES content fix(Offline): Allow downloading AES content Jan 3, 2025
Also adds integration tests for DASH AES-128 and HLS SAMPLE-AES download and playback
@avelad avelad force-pushed the store-aes-sample-aes branch from 4dbd2ff to 31ab38c Compare January 3, 2025 13:28
lib/hls/hls_parser.js Show resolved Hide resolved
lib/offline/storage.js Show resolved Hide resolved
@avelad avelad requested a review from theodab January 7, 2025 07:40
@avelad
Copy link
Member Author

avelad commented Jan 7, 2025

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7827

@avelad avelad merged commit 21bbd93 into shaka-project:main Jan 7, 2025
33 checks passed
@avelad avelad deleted the store-aes-sample-aes branch January 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: offline The issue involves the offline storage system of Shaka Player priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants