Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infiniteLiveStreamDuration: true prevents goToLive from advancing more than a few seconds #7903

Closed
rbertramResi opened this issue Jan 17, 2025 · 2 comments · Fixed by #7905
Closed
Assignees
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Milestone

Comments

@rbertramResi
Copy link

rbertramResi commented Jan 17, 2025

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Does not appear related

What version of Shaka Player are you using?

4.10.21 and replicated on both 4.12.8 and nightly from index page (https://index-dot-shaka-player-demo.appspot.com/)

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Both iOS Safari and MacOS Google Chrome

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
n/a

What are the manifest and license server URIs?

Any live URL

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

{
"manifest": {
"retryParameters": {
"maxAttempts": 3,
"timeout": 15000
}
},
"streaming": {
"retryParameters": {
"maxAttempts": 3,
"timeout": 15000
},
"bufferingGoal": 15,
"infiniteLiveStreamDuration": true
},
"abr": {
"defaultBandwidthEstimate": 1593069.306930693,
"restrictions": {
"maxHeight": 1080
}
},
"preferredAudioLanguage": "en",
"preferredTextLanguage": "en"
}

What did you do?

Play live video, scrub backwards, click a button that calls go to live. Our player has a live function, and the shaka's UI seems to do the same. (instead of calling goToLive, it goes to seekRange end which is the same (presentation_time.js at around line 40)

What did you expect to happen?
The video would go to the end of the available streaming content.

What actually happened?

The video advanced around 5-10 seconds, it didn't appear to be a consistent interval.

This video shows the bug with the setting turned on, then I turn it off, reload the page and show that it works with it off

bug.mp4

Are you planning to send a PR to fix it?
No

@avelad
Copy link
Member

avelad commented Jan 17, 2025

@joeyparrish can you review it? (It can be reproduced with Shaka Player History by seeking to the past and then to the present with the UI) Thanks!

@avelad avelad added priority: P2 Smaller impact or easy workaround priority: P1 Big impact or workaround impractical; resolve before feature release and removed priority: P2 Smaller impact or easy workaround labels Jan 17, 2025
@shaka-bot shaka-bot added this to the v4.13 milestone Jan 17, 2025
@avelad
Copy link
Member

avelad commented Jan 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants