fix: Multivariant HLS manifests don't work with DRM

[gmcgarry]

For Reference, DASH manifest is: https://content.media24.link/hls/flicker84/playready/manifest.mpd

Problematic HLS manifests:

PlayReady: https://content.media24.link/hls/flicker84/playready/master.m3u8
FairPlay: https://content.media24.link/hls/flicker84/fairplay/master.m3u8

This specifically happened with a test for supplemental codecs, because the implementation of HLS SUPPLEMENTAL-CODECS duplicates the variant for all the supplemental codecs. But the same behaviour could be done by explicitly providing multiple variants in the manifest.

The problematic code is in lib/hls/hls_parser.js, method parseManifest_():

    if (variants.length == 1) {
      const createSegmentIndexPromises = [];
      const variant = variants[0];
      for (const stream of [variant.video, variant.audio]) {
        if (stream && !stream.segmentIndex) {
          createSegmentIndexPromises.push(stream.createSegmentIndex());
        }
      }
      if (createSegmentIndexPromises.length > 0) {
        await Promise.all(createSegmentIndexPromises);
      }
    }

This code will only invoke stream.createSegmentIndex() when one variant is available. If it isn't invoked, then the download of the media manifest is deferred, the EXT-X-KEY in the media manifest is not parsed and the code in shaka.media.PreloadManager.initializeDrmInner() never detects any DrmInfos.

Not sure why this code is only invoked if one variant is available. Maybe an optimisation in the common case, which is now a required code path.

[shaka-bot]

Incremental code coverage: 100.00%

[avelad]

I'm not convinced by this solution... I'll think of a better solution.

[avelad]

@gmcgarry I have seen that your content is generated with Shaka Packager, use the --create_session_keys option for it to work correctly. Can you tell me if that works for you without any changes? Thanks!

[shaka-bot]

Closing due to inactivity. If the author would like to continue this PR, they can reopen it (preferred) or start a new one (if needed).