From 0917fc2e931452e5b6476d9dd7014a6b386fbd6a Mon Sep 17 00:00:00 2001 From: kotarella1110 Date: Mon, 20 Nov 2023 21:54:13 +0900 Subject: [PATCH 1/2] fix: fix RailsContext type --- node_package/src/types/index.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/node_package/src/types/index.ts b/node_package/src/types/index.ts index 312157821..06ce51ae7 100644 --- a/node_package/src/types/index.ts +++ b/node_package/src/types/index.ts @@ -17,14 +17,13 @@ export interface RailsContext { rorPro: boolean; rorProVersion?: string; serverSide: boolean; - originalUrl: string; href: string; location: string; scheme: string; host: string; - port: string; + port: number | null; pathname: string; - search: string; + search: string | null; httpAcceptLanguage: string; } From 3e5e30d769a381f74c9cc87a1bb381993bcb073f Mon Sep 17 00:00:00 2001 From: kotarella1110 Date: Tue, 21 Nov 2023 20:00:45 +0900 Subject: [PATCH 2/2] chore: update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 18a5f2f9f..af3b2d41a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ Changes since the last non-beta release. ### [13.4.1] #### Fixed - Fixed Typescript types for ServerRenderResult, ReactComponent, and RenderFunction interfaces. [PR 1582](https://github.com/shakacode/react_on_rails/pull/1582) by [kotarella1110](https://github.com/kotarella1110) +- Fixed Typescript types for RailsContext interfaces. [PR 1585](https://github.com/shakacode/react_on_rails/pull/1585) by [kotarella1110](https://github.com/kotarella1110) - Removed a workaround in `JsonOutput#escape` for an no-longer supported Rails version. Additionally, removed `Utils.rails_version_less_than_4_1_1` which was only used in the workaround. [PR 1580](https://github.com/shakacode/react_on_rails/pull/1580) by [wwahammy](https://github.com/wwahammy)