Are the '@babel/preset-typescript' options in the provided babel presets sensible?

[jennysharps]

At the moment, the typescript babel preset looks like this:

https://github.com/shakacode/shakapacker/blob/master/package/babel/preset.js#L33

[
  '@babel/preset-typescript',
  { allExtensions: true, isTSX: true }
]

According to this issue babel/babel#8924, isTSX & allExtensions being set to true means the entire codebase is expected to be typescript. I'm trying to use the provided preset, but as my codebase is a combination of js & ts, I get errors.

Would it not be more sensible of a default to pass in no options in the preset? Especially given the fact that one of the benefits of using typescript is the ability to introduce it incrementally to existing codebases.

[justin808]

I agree! This change was introduced here, many years ago.
https://github.com/shakacode/shakapacker/blame/master/package/babel/preset.js#L33

This would be a "breaking" change, so it's great for the upcoming v7!

[justin808]

#267 is the tracking issue. Thanks, @jennysharps!

[ahangarha]

@jennysharps
Please check #273